Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(core): post to test channel when triggering the job manually. #1730

Merged
merged 3 commits into from
Jan 16, 2025
Merged

ci(core): post to test channel when triggering the job manually. #1730

merged 3 commits into from
Jan 16, 2025

Conversation

mpaulucci
Copy link
Collaborator

Motivation
To not spam the official slack channels when testing functionality

Description

  • Change from l1 slack channel to reports channel
  • Post to test channel when triggering through dispatch

@mpaulucci mpaulucci requested a review from a team as a code owner January 16, 2025 17:00
@mpaulucci mpaulucci force-pushed the improve-slack-posting branch from f9cf056 to 674fae0 Compare January 16, 2025 17:05
fkrause98
fkrause98 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@fkrause98 fkrause98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading 

| File                                                     | Lines | Diff |
+----------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/levm/src/vm.rs | 1030  | +5   |
+----------------------------------------------------------+-------+------+

Total lines added: +5
Total lines removed: 0
Total lines changed: 5

mpaulucci and others added 2 commits January 16, 2025 18:36
@mpaulucci
Remove ternary operator.
7f64efe
@mpaulucci @ilitteri
Update .github/workflows/daily_reports.yaml
d9ad33c 
Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
@mpaulucci mpaulucci enabled auto-merge January 16, 2025 17:55
@mpaulucci mpaulucci added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 0915896 Jan 16, 2025
21 checks passed
@mpaulucci mpaulucci deleted the improve-slack-posting branch January 16, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri left review comments

@fkrause98 fkrause98 fkrause98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpaulucci @fkrause98 @ilitteri