Skip to content

Commit

Permalink
Unskip passing tests on deneb.
Browse files Browse the repository at this point in the history
  • Loading branch information
mpaulucci authored and MegaRedHand committed Mar 14, 2024
1 parent 36436ee commit 3344ce4
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 7 deletions.
5 changes: 2 additions & 3 deletions test/spec/runners/finality.ex
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@ defmodule FinalityTestRunner do
end

@impl TestRunner
def skip?(%SpecTestCase{fork: "deneb", case: _testcase}) do
# TODO: all of them fail
true
def skip?(%SpecTestCase{fork: "deneb", case: testcase}) do
Enum.member?(@disabled_cases, testcase)
end

@impl TestRunner
Expand Down
3 changes: 2 additions & 1 deletion test/spec/runners/helpers/process_blocks.ex
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ defmodule Helpers.ProcessBlocks do
alias LambdaEthereumConsensus.StateTransition
alias LambdaEthereumConsensus.Utils.Diff
alias Types.BeaconState
alias Types.SignedBeaconBlock

use HardForkAliasInjection

Expand All @@ -27,7 +28,7 @@ defmodule Helpers.ProcessBlocks do
|> Enum.map(fn index ->
SpecTestUtils.read_ssz_from_file!(
case_dir <> "/blocks_#{index}.ssz_snappy",
Types.SignedBeaconBlock
SignedBeaconBlock
)
end)

Expand Down
5 changes: 5 additions & 0 deletions test/spec/runners/random.ex
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ defmodule RandomTestRunner do
true
end

@impl TestRunner
def skip?(%SpecTestCase{fork: "deneb", case: testcase}) do
Enum.member?(@disabled_cases, testcase)
end

@impl TestRunner
def skip?(_), do: true

Expand Down
9 changes: 6 additions & 3 deletions test/spec/runners/sanity.ex
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,12 @@ defmodule SanityTestRunner do
Enum.member?(@disabled_slot_cases, testcase)
end

def skip?(%SpecTestCase{fork: "deneb"}) do
# TODO: all of them fail
true
def skip?(%SpecTestCase{fork: "deneb", handler: "blocks", case: testcase}) do
Enum.member?(@disabled_block_cases, testcase)
end

def skip?(%SpecTestCase{fork: "deneb", handler: "slots", case: testcase}) do
Enum.member?(@disabled_slot_cases, testcase)
end

def skip?(_), do: true
Expand Down

0 comments on commit 3344ce4

Please sign in to comment.