refactor: remove tuple in Validator.new()

lambdaclass · Aug 12, 2024 · 9ba0925 · 9ba0925
1 parent c0478ab
commit 9ba0925
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/lambda_ethereum_consensus/validator/setup.ex b/lib/lambda_ethereum_consensus/validator/setup.ex
@@ -30,7 +30,7 @@ defmodule LambdaEthereumConsensus.Validator.Setup do
     validators =
       validator_keystores
       |> Enum.map(fn keystore ->
-        {keystore.pubkey, Validator.new({slot, head_root, keystore})}
+        {keystore.pubkey, Validator.new(slot, head_root, keystore)}
       end)
       |> Map.new()
 

diff --git a/lib/lambda_ethereum_consensus/validator/validator.ex b/lib/lambda_ethereum_consensus/validator/validator.ex
@@ -44,8 +44,8 @@ defmodule LambdaEthereumConsensus.Validator do
           payload_builder: {Types.slot(), Types.root(), BlockBuilder.payload_id()} | nil
         }
 
-  @spec new({Types.slot(), Types.root(), Keystore.t()}) :: state()
-  def new({head_slot, head_root, keystore}) do
+  @spec new(Types.slot(), Types.root(), Keystore.t()) :: state()
+  def new(head_slot, head_root, keystore) do
     state = %__MODULE__{
       slot: head_slot,
       epoch: Misc.compute_epoch_at_slot(head_slot),

diff --git a/lib/libp2p_port.ex b/lib/libp2p_port.ex
@@ -560,7 +560,7 @@ defmodule LambdaEthereumConsensus.Libp2pPort do
   def handle_call({:add_validator, keystore}, _from, %{validators: validators} = state) do
     # TODO (#1263): handle 0 validators
     first_validator = validators |> Map.values() |> List.first()
-    validator = Validator.new({first_validator.slot, first_validator.root, keystore})
+    validator = Validator.new(first_validator.slot, first_validator.root, keystore)
 
     Logger.warning(
       "[Libp2pPort] Adding validator with index #{inspect(validator.index)}. head_slot: #{inspect(validator.slot)}."