Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ERC-2335 compatible keystore #1013

Merged
merged 9 commits into from
Apr 23, 2024
Merged

feat: add ERC-2335 compatible keystore #1013

merged 9 commits into from
Apr 23, 2024

Conversation

MegaRedHand
Copy link
Collaborator

@MegaRedHand MegaRedHand commented Apr 19, 2024

Closes #821

This adds a simple implementation for ERC-2335 keystores. Things to tackle in other PRs:

  • expose in CLI
  • derive public key from secret key
  • add pbkdf2
  • support EIP-2333 paths

@MegaRedHand MegaRedHand self-assigned this Apr 19, 2024
@MegaRedHand MegaRedHand marked this pull request as ready for review April 22, 2024 13:47
@MegaRedHand MegaRedHand requested a review from a team as a code owner April 22, 2024 13:47
Copy link
Collaborator

@mpaulucci mpaulucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkenan Arkenan merged commit a30602e into main Apr 23, 2024
12 checks passed
@Arkenan Arkenan deleted the erc-2335-keystore branch April 23, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Implement EIP-2335 compliant keystore
3 participants