Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make discovery port configurable #1014

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Conversation

Arkenan
Copy link
Collaborator

@Arkenan Arkenan commented Apr 22, 2024

Motivation

Local testnets require ports to be configured so they don't collide with other local running nodes.

Description

  • Adds configuration in runtime.exs for discovery port.

Closes #810

@Arkenan Arkenan marked this pull request as ready for review April 23, 2024 14:38
@Arkenan Arkenan requested a review from a team as a code owner April 23, 2024 14:38
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkenan Arkenan merged commit 01d0827 into main Apr 23, 2024
12 checks passed
@Arkenan Arkenan deleted the libp2p_configurable_ports branch April 23, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Allow configuring ports used by Libp2p
2 participants