Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove genserver behavior from pending blocks #1141

Merged
merged 46 commits into from
Jul 4, 2024
Merged

refactor: remove genserver behavior from pending blocks #1141

merged 46 commits into from
Jul 4, 2024

Conversation

Arkenan
Copy link
Collaborator

@Arkenan Arkenan commented Jun 11, 2024 •
edited
Loading

Changes:

  • Removes pending blocks genserver behavior
  • Creates Response proto for to differentiate results that come from requests, adding protocol_id as metadata.
  • Adds async requests that are dispatched by libp2p port instead of being sent to the requester.
  • Makes BlockDownloader and BlobDownloader's requests async.
  • Integrates handling of async responses with block and blob downloaders.
  • Makes pending blocks download blobs and blocks reactively.

Closes #1122 #1121

Arkenan added 25 commits June 3, 2024 18:27
@Arkenan
remove pending blocks state. It compiles, but get_blocks_with_status …
680447d 
…still needs to be written
@Arkenan
fix dialyzer
e34441e
@Arkenan
Merge remote-tracking branch 'origin/main' into replace_pending_block…
0a38ad3 
…s_state_with_db
@Arkenan
readd underscore
4e2a163
@Arkenan
add status lists
6f094b3
@Arkenan
only use blocks wrappers
7d261c7
@Arkenan
Merge remote-tracking branch 'origin/main' into replace_pending_block…
9c97f55 
…s_state_with_db
@Arkenan
Add tests and fix the cache to enable block updates
71100ab
@Arkenan
simplify pending blocks code for add_block
a15f343
@Arkenan
Merge remote-tracking branch 'origin/main' into replace_pending_block…
f17486d 
…s_state_with_db
@Arkenan
fix fork choice call
5f486ea
@Arkenan
remove unused alias
a98d289
@Arkenan
add cases for the get_blocks_with_status calls
e6afeec
@Arkenan
take blockinfo out. Make the put a call in LRU cache. Fix nil/downloa…
02de936 
…d cases
@Arkenan
add block info
862d4d8
@Arkenan
fix lint
3d808ef
@Arkenan
Merge remote-tracking branch 'origin/main' into replace_pending_block…
1f5226d 
…s_state_with_db
@Arkenan
change handle_info to handle_casts
6dc0b04
@Arkenan
Make LRU cache writes to be calls
6eefe07
@Arkenan
Remove io inspects
4c5498a
@Arkenan
Merge branch 'main' into replace_pending_blocks_state_with_db
db68778
@Arkenan
adding some logs to debug ci
41618b9
@Arkenan
Merge branch 'main' into replace_pending_blocks_state_with_db
3297363
@Arkenan
Everything compiling
efcd70d
@Arkenan
Merge remote-tracking branch 'origin/main' into remove_genserver_beha…
9c972b7 
…vior_from_pending_blocks
@Arkenan Arkenan changed the title Remove genserver behavior from pending blocks refactor: remove genserver behavior from pending blocks Jun 11, 2024
@Arkenan Arkenan marked this pull request as ready for review July 2, 2024 17:16
@Arkenan Arkenan requested a review from a team as a code owner July 2, 2024 17:16
avilagaston9
avilagaston9 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

lib/lambda_ethereum_consensus/beacon/pending_blocks.ex Show resolved Hide resolved
lib/lambda_ethereum_consensus/beacon/pending_blocks.ex Show resolved Hide resolved
test/unit/p2p/requests_test.exs Outdated Show resolved Hide resolved
@Arkenan @avilagaston9
Update test/unit/p2p/requests_test.exs
305b1ab 
Co-authored-by: Avila Gastón <72628438+avilagaston9@users.noreply.github.com>
@Arkenan Arkenan merged commit 3e2f78d into main Jul 4, 2024
19 checks passed
@Arkenan Arkenan deleted the remove_genserver_behavior_from_pending_blocks branch July 4, 2024 14:44
avilagaston9 added a commit that referenced this pull request Jul 4, 2024
@Arkenan @avilagaston9
refactor: remove genserver behavior from pending blocks (#1141)
7b1f204 
Co-authored-by: Avila Gastón <72628438+avilagaston9@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avilagaston9 avilagaston9 avilagaston9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pending blocks refactor] Remove add_block cast
2 participants
@Arkenan @avilagaston9