Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(warnings): fixed some error and warning messages seen throughout tests #1227

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

rodrigo-o
Copy link
Collaborator

@rodrigo-o rodrigo-o commented Jul 17, 2024

Motivation

This small PR address or comment some error/warnings encountered during the Node execution

Description

None of this were critical, but they were easy to solve so compiled them in this PR, this are the ones tackled:

libGLU.so.1

~c"Failed to load NIF library /usr/local/lib/erlang/lib/wx-2.4.1/priv/erl_gl: 'libGLU.so.1: cannot open shared object file: No such file or directory'"}}

This was due to the addition of :wx as an extra application by default which needed additional libraries installed in docker but couldn't be used directly. I added an EXTRA_APPLICATIONS env variable to deal with this. By default :wx is not part of the default extra_applications, it's just added if EXTRA_APPLICATIONS=WX is set. This is also specified in the only section of the README that talks about :observer with a small note.

Alternative solution: We could just add :wx for dev, not prod, but i'm not sure that's exactly what we want, this was a quick fix for the issue and still allows for someone testing with observer and wx to just set it up for any env without modifying the mix.exs. For a more complex alternative (maybe for the future) like SSH tunnels with the docker container here is an elixir forum thread and an example repo

eth/v1/node/version API

2024-07-16 13:26:11 DEBUG 16:26:11.852 Processing with BeaconApi.ErrorController.not_found/2
2024-07-16 13:26:11   Parameters: %{"path" => ["eth", "v1", "node", "version"]}

This was related to the simple version RPC method. That was the only one appearing in the logs, so I though of tackle it. But unfortunately it was because that failure stopped kurtosis for continuing reaching the API. once added it started asking for the next endpoint: eth/v1/node/syncing. It'll probably will continue needing more unimplemented methods so I stopped on just this one.

JSONArgs on Docker ENTRYPOINT

 - JSONArgsRecommended: JSON arguments recommended for ENTRYPOINT to prevent unintended behavior related to OS signals (line 123)

The issue here is that OS signals like SIGTERM and SIGKILL can't be received using shell-like syntax. This could impact graceful shutdowns for example. Unfortunately this can't be solved without losing the ability to set a COOKIE through params (a change added alongside the spawn of a node for connecting to the running instance in docker). Right now this is not a big issue, but in the future we can move to releases

…t Docker start.

Added a small note in the :etop section that mentioned :observer to explai how to add :wx to extra_applications without modifiying the mix.exs file.
@rodrigo-o rodrigo-o marked this pull request as ready for review July 17, 2024 22:24
@rodrigo-o rodrigo-o requested a review from a team as a code owner July 17, 2024 22:24
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

@Arkenan Arkenan merged commit 9ae9ac5 into main Jul 18, 2024
19 checks passed
@Arkenan Arkenan deleted the error-messages-through-kurtosis branch July 18, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants