chore(warnings): fixed some error and warning messages seen throughout tests #1227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This small PR address or comment some error/warnings encountered during the Node execution
Description
None of this were critical, but they were easy to solve so compiled them in this PR, this are the ones tackled:
libGLU.so.1
This was due to the addition of
:wx
as an extra application by default which needed additional libraries installed in docker but couldn't be used directly. I added anEXTRA_APPLICATIONS
env variable to deal with this. By default:wx
is not part of the defaultextra_applications
, it's just added ifEXTRA_APPLICATIONS=WX
is set. This is also specified in the only section of the README that talks about:observer
with a small note.Alternative solution: We could just add
:wx
fordev
, notprod
, but i'm not sure that's exactly what we want, this was a quick fix for the issue and still allows for someone testing with observer and wx to just set it up for any env without modifying themix.exs
. For a more complex alternative (maybe for the future) like SSH tunnels with the docker container here is an elixir forum thread and an example repoeth/v1/node/version API
This was related to the simple version RPC method. That was the only one appearing in the logs, so I though of tackle it. But unfortunately it was because that failure stopped kurtosis for continuing reaching the API. once added it started asking for the next endpoint:
eth/v1/node/syncing
. It'll probably will continue needing more unimplemented methods so I stopped on just this one.JSONArgs on Docker ENTRYPOINT
The issue here is that OS signals like SIGTERM and SIGKILL can't be received using shell-like syntax. This could impact graceful shutdowns for example. Unfortunately this can't be solved without losing the ability to set a COOKIE through params (a change added alongside the spawn of a node for connecting to the running instance in docker). Right now this is not a big issue, but in the future we can move to releases