Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fork choice metrics #1232

Merged
merged 2 commits into from
Jul 22, 2024
Merged

feat: fork choice metrics #1232

merged 2 commits into from
Jul 22, 2024

Conversation

Arkenan
Copy link
Collaborator

@Arkenan Arkenan commented Jul 19, 2024

Metrics added in a hierarchy:

  • handler: block processing, attestation processing, attester slashing.
  • transition section: block vs epoch processing.
  • operations: randao, attestation batch, withdrawals, etc.

Also added grafana panel with pie chart for execution times for each section. Might eventually move to span profiles if we introduce pyroscope.

Closes #1211

@Arkenan Arkenan changed the title Add metrics for block processing, its subsections, attestation and at… feat: fork choice metrics Jul 19, 2024
@Arkenan Arkenan marked this pull request as ready for review July 19, 2024 10:51
@Arkenan Arkenan requested a review from a team as a code owner July 19, 2024 10:51
Copy link
Contributor

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arkenan Arkenan merged commit e163ec6 into main Jul 22, 2024
20 checks passed
@Arkenan Arkenan deleted the fork_choice_metrics branch July 22, 2024 16:06
avilagaston9 pushed a commit that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add metrics for state transition times.
2 participants