feat: implement BeaconBlocksByRoot libp2p handler #471

h3lio5 · 2023-11-29T06:35:22Z

Motivation

Implements the BeaconBlocksByRoot p2p handler.

Closes #446

native/ssz_nif/src/elx_types/p2p.rs

lib/lambda_ethereum_consensus/p2p/incoming_requests/handler.ex

MegaRedHand

LGTM. We should add the request to the list on LambdaEthereumConsensus.P2P.IncomingRequests.Receiver, so peers can use it.

mpaulucci

Could you add a "unit" test that makes an interaction between this function and https://github.com/lambdaclass/lambda_ethereum_consensus/blob/main/lib/lambda_ethereum_consensus/p2p/block_downloader.ex#L84 ?

You could patch Libp2pPort.send_request and make that one call the function you implemented. And then you could also patch Libp2pPort.send_response(message_id, response_chunk).

See: https://hexdocs.pm/patch/readme.html

mpaulucci · 2023-12-07T14:57:39Z

@h3lio5 is it clear what's being asked? We can have a call if not clear

test/unit/p2p_blocks_test.exs

lib/ssz_types/p2p/beacon_blocks_ by_root_response.ex

lib/ssz_types/p2p/beacon_blocks_by_root_request.ex

test/unit/p2p_blocks_test.exs

MegaRedHand · 2023-12-15T12:12:56Z

test/unit/p2p_blocks_test.exs

+    BlockStore.store_block(signed_block_input)
+
+    # ssz serialize and snappy compress the block root
+    with {:ok, ssz_serialized} <- Ssz.to_ssz(BeaconBlocksByRootRequest{body: [block_root]}),


Suggested change

with {:ok, ssz_serialized} <- Ssz.to_ssz(BeaconBlocksByRootRequest{body: [block_root]}),

with {:ok, ssz_serialized} <- Ssz.to_ssz(%BeaconBlocksByRootRequest{body: [block_root]}),

MegaRedHand · 2023-12-15T12:13:57Z

test/unit/p2p_blocks_test.exs

+  alias LambdaEthereumConsensus.Store.Db
+
+  setup do
+    expose(Handler, :all)


We don't need to expose the Handler functions anymore.

MegaRedHand · 2023-12-15T12:47:11Z

You need to add the new types to the schema_match macro

test/unit/p2p_blocks_test.exs

MegaRedHand

As talked in the daily, we should split this into two PRs: one with the new feature, and another with the tests

MegaRedHand

Summarizing what's left to do in this PR:

remove test/unit/p2p_blocks_test.exs (it should be re-added in another PR)
merge main
address comments

lib/lambda_ethereum_consensus/p2p/incoming_requests/handler.ex

Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>

) Co-authored-by: Martin Paulucci <martin.paulucci@lambdaclass.com>

lambdaclass#552)

…class#550)

)

Co-authored-by: Martin Paulucci <mpaulucci@Martins-MacBook-Pro.local>

lib/types/p2p/beacon_blocks_ by_root_request.ex

lib/types/p2p/beacon_blocks_by_root_response.ex

lib/types/p2p/beacon_blocks_ by_root_request.ex

lib/types/p2p/beacon_blocks_by_root_response.ex

native/ssz_nif/src/elx_types/p2p.rs

lib/lambda_ethereum_consensus/p2p/incoming_requests/handler.ex

MegaRedHand · 2024-01-15T14:08:22Z

Lints are failing. Could you run make fmt and push the changes?

feat: implement BeaconBlocksByRoot libp2p handler

953002e

h3lio5 requested a review from a team as a code owner November 29, 2023 06:35

h3lio5 added 2 commits November 29, 2023 12:05

Merge branch 'main' into p2p-beacon-blocks-by-root

2f9bc77

fix lint error

c9e47dc

MegaRedHand reviewed Nov 29, 2023

View reviewed changes

native/ssz_nif/src/elx_types/p2p.rs Outdated Show resolved Hide resolved

lib/lambda_ethereum_consensus/p2p/incoming_requests/handler.ex Outdated Show resolved Hide resolved

h3lio5 added 2 commits November 30, 2023 14:10

remove logs

97e6707

Merge branch 'main' into p2p-beacon-blocks-by-root

a0b7c23

MegaRedHand reviewed Nov 30, 2023

View reviewed changes

lib/lambda_ethereum_consensus/p2p/incoming_requests/handler.ex Outdated Show resolved Hide resolved

fixed a minor bug

fd2b09e

MegaRedHand reviewed Nov 30, 2023

View reviewed changes

MegaRedHand previously approved these changes Nov 30, 2023

View reviewed changes

mpaulucci requested changes Nov 30, 2023

View reviewed changes

h3lio5 added 5 commits December 8, 2023 11:51

Merge branch 'main' into p2p-beacon-blocks-by-root

4917cf3

add beacon_blocks_by_root to the list for discovery

961e746

add unit test to BeaconBlocksByRoot handler

d50cf7b

fix some bugs

5c2a4f8

minor bug fix

9a13e4d

MegaRedHand reviewed Dec 11, 2023

View reviewed changes

test/unit/p2p_blocks_test.exs Outdated Show resolved Hide resolved

test/unit/p2p_blocks_test.exs Outdated Show resolved Hide resolved

MegaRedHand reviewed Dec 13, 2023

View reviewed changes

lib/ssz_types/p2p/beacon_blocks_ by_root_response.ex Outdated Show resolved Hide resolved

lib/ssz_types/p2p/beacon_blocks_by_root_request.ex Outdated Show resolved Hide resolved

fix some bugs

8830785

mpaulucci reviewed Dec 14, 2023

View reviewed changes

test/unit/p2p_blocks_test.exs Outdated Show resolved Hide resolved

MegaRedHand reviewed Dec 15, 2023

View reviewed changes

add type in match_schema

8952ec5

MegaRedHand reviewed Dec 15, 2023

View reviewed changes

test/unit/p2p_blocks_test.exs Outdated Show resolved Hide resolved

MegaRedHand reviewed Dec 18, 2023

View reviewed changes

h3lio5 dismissed MegaRedHand’s stale review via 8952ec5 December 18, 2023 22:17

MegaRedHand reviewed Jan 2, 2024

View reviewed changes

Update lib/lambda_ethereum_consensus/p2p/incoming_requests/handler.ex

27ad0fa

Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>

mpaulucci and others added 19 commits January 5, 2024 18:34

fix: rename cli options related to execution client. (lambdaclass#537)

fc6b673

chore: rename SszTypes to Types (lambdaclass#539)

cbaaa0e

docs: add GetMetadata example (lambdaclass#538)

027c82c

fix: allow not passing --execution-jwt flag (lambdaclass#542)

0a3c7e8

perf: batched attestation processing (lambdaclass#533)

b558b39

fix: bitvector creation and serialization (lambdaclass#547)

6c534c3

Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>

refactor: allow for more networks apart from mainnet (lambdaclass#546)

3047560

refactor: move config to runtime.exs. (lambdaclass#548)

09261d0

feat: implement rewards spec test runner (lambdaclass#536)

af37663

fix: was using SszTypes in rewards spec-test runner (lambdaclass#551

992f591

) Co-authored-by: Martin Paulucci <martin.paulucci@lambdaclass.com>

feat: download anchor block from checkpoint sync api instead of peers. (

f435301

lambdaclass#552)

perf: store validators in array (lambdaclass#544)

c3e7c73

perf: store X_epoch_participation and balances in vectors (lambda…

058a951

…class#550)

perf: optimize process_justification_and_finalization (lambdaclass#555

61280ac

)

refactor: add beacon node supervisor. (lambdaclass#566)

62cbc9a

Co-authored-by: Martin Paulucci <mpaulucci@Martins-MacBook-Pro.local>

feat: add bitlist and bitvector ssz support (lambdaclass#494)

1920bf7

fix: process block attestations and slashings (lambdaclass#567)

dcd6261

fix: run mix clean on clean target (lambdaclass#575)

817633c

Merge branch 'main' into p2p-beacon-blocks-by-root

b3a2a8d

MegaRedHand reviewed Jan 5, 2024

View reviewed changes

h3lio5 added 2 commits January 8, 2024 13:52

Merge branch 'main' into p2p-beacon-blocks-by-root

ce81aad

replace SszTypes with Types

ffee49f

MegaRedHand reviewed Jan 8, 2024

View reviewed changes

lib/lambda_ethereum_consensus/p2p/incoming_requests/handler.ex Show resolved Hide resolved

MegaRedHand assigned h3lio5 Jan 12, 2024

MegaRedHand and others added 2 commits January 12, 2024 14:12

Merge branch 'main' into p2p-beacon-blocks-by-root

f1b5e61

refactor

c9b8c72

fix lint errors

ef13ecf

mpaulucci approved these changes Jan 16, 2024

View reviewed changes

MegaRedHand merged commit a14b387 into lambdaclass:main Jan 16, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement BeaconBlocksByRoot libp2p handler #471

feat: implement BeaconBlocksByRoot libp2p handler #471

h3lio5 commented Nov 29, 2023

MegaRedHand left a comment

mpaulucci left a comment

mpaulucci commented Dec 7, 2023

MegaRedHand Dec 15, 2023

MegaRedHand Dec 15, 2023

MegaRedHand commented Dec 15, 2023

MegaRedHand left a comment

MegaRedHand left a comment •

edited by h3lio5

Loading

MegaRedHand commented Jan 15, 2024

	with {:ok, ssz_serialized} <- Ssz.to_ssz(BeaconBlocksByRootRequest{body: [block_root]}),
	with {:ok, ssz_serialized} <- Ssz.to_ssz(%BeaconBlocksByRootRequest{body: [block_root]}),

feat: implement BeaconBlocksByRoot libp2p handler #471

feat: implement BeaconBlocksByRoot libp2p handler #471

Conversation

h3lio5 commented Nov 29, 2023

MegaRedHand left a comment

Choose a reason for hiding this comment

mpaulucci left a comment

Choose a reason for hiding this comment

mpaulucci commented Dec 7, 2023

MegaRedHand Dec 15, 2023

Choose a reason for hiding this comment

MegaRedHand Dec 15, 2023

Choose a reason for hiding this comment

MegaRedHand commented Dec 15, 2023

MegaRedHand left a comment

Choose a reason for hiding this comment

MegaRedHand left a comment • edited by h3lio5 Loading

Choose a reason for hiding this comment

MegaRedHand commented Jan 15, 2024

MegaRedHand left a comment •

edited by h3lio5

Loading