perf: optimize process_withdrawals and process_sync_committee_updates
#486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
force-pushed
the
optimize-withdrawals-sync_committee_updates
branch
from
b63413c to
eb2067c
Compare
mpaulucci
reviewed
Nov 30, 2023
| state.validators | ||
| |> Stream.filter(&Predicates.is_active_validator(&1, epoch)) | ||
| |> Stream.map(fn %Validator{effective_balance: effective_balance} -> effective_balance end) | ||
| |> Enum.sum() |
There was a problem hiding this comment.
is there any benefit in using stream here considering that you are going to do a Enum.sum afterwards?
There was a problem hiding this comment.
We would need benchmarks to know whether Stream or Enum is more efficient for this case, but at least it should consume less memory, as it can sum the result in batches, instead of first transforming the whole list and then reducing it.
mpaulucci
reviewed
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.