Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement ssz_generic spec tests #490

Merged

Conversation

f3r10
Copy link
Contributor

@f3r10 f3r10 commented Nov 30, 2023

Motivation

Closes #460

@f3r10 f3r10 requested a review from a team as a code owner November 30, 2023 18:03
lib/spec/runners/ssz_generic.ex Outdated Show resolved Hide resolved
lib/spec/runners/ssz_generic.ex Outdated Show resolved Hide resolved
lib/ssz_ex.ex Outdated Show resolved Hide resolved
lib/spec/runners/ssz_generic.ex Outdated Show resolved Hide resolved
lib/ssz_ex.ex Outdated Show resolved Hide resolved
@f3r10 f3r10 requested a review from MegaRedHand December 7, 2023 11:42
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor changes. Otherwise, LGTM

lib/spec/runners/ssz_generic.ex Outdated Show resolved Hide resolved
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 🔥

@MegaRedHand MegaRedHand merged commit 30f8538 into lambdaclass:main Dec 11, 2023
9 checks passed
h3lio5 pushed a commit to h3lio5/lambda_ethereum_consensus that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ssz_generic spec tests
2 participants