-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement ssz_generic
spec tests
#490
Merged
MegaRedHand
merged 9 commits into
lambdaclass:main
from
f3r10:ssz_implement_ssz_generic_spec_tests
Dec 11, 2023
Merged
feat: implement ssz_generic
spec tests
#490
MegaRedHand
merged 9 commits into
lambdaclass:main
from
f3r10:ssz_implement_ssz_generic_spec_tests
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
reviewed
Nov 30, 2023
MegaRedHand
reviewed
Dec 1, 2023
MegaRedHand
reviewed
Dec 1, 2023
MegaRedHand
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor changes. Otherwise, LGTM
lib/spec/runners/helpers/ssz_static_containers/var_test_struct.ex
Outdated
Show resolved
Hide resolved
lib/spec/runners/helpers/ssz_static_containers/small_test_struct.ex
Outdated
Show resolved
Hide resolved
MegaRedHand
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 🔥
h3lio5
pushed a commit
to h3lio5/lambda_ethereum_consensus
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #460