Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bitlist and bitvector ssz support #494
feat: add bitlist and bitvector ssz support #494
Changes from 5 commits
d07bfe6
8f3c9ac
921cacf
131110c
99455c9
ddfa37d
c3469ed
6d76ef0
c68f049
804a6b3
14acee0
90373c3
df5f4fc
8ab03e4
1e75712
001efed
85c8bc6
e1a04d9
f31f1f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of
{:ok, bit_vector}
here let's return{:ok, BitVector.to_bytes(bit_vector)}
, which is a fix that has been added a couple of weeks ago (BitVector.new()
was modified too).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a warning about the opaque type:
Call does not have expected opaque term of type LambdaEthereumConsensus.Utils.BitVector.t() in the 1st position
🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a
BitVector.bit_size
guard in theBitVector
and use it here to see if the issue gets fixed? On guards: https://hexdocs.pm/elixir/main/Kernel.html#defguard/1