Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ping metadata #516

Merged
merged 46 commits into from
Jan 12, 2024
Merged

feat: ping metadata #516

merged 46 commits into from
Jan 12, 2024

Conversation

karasakalmt
Copy link
Contributor

@karasakalmt karasakalmt commented Dec 12, 2023 •
edited
Loading

Closes #445

@karasakalmt karasakalmt requested a review from Arkenan December 12, 2023 11:17
@karasakalmt karasakalmt marked this pull request as ready for review December 13, 2023 13:09
@karasakalmt karasakalmt requested a review from a team as a code owner December 13, 2023 13:09
@karasakalmt karasakalmt marked this pull request as draft December 14, 2023 13:38
@karasakalmt karasakalmt requested a review from Arkenan January 3, 2024 12:19
mpaulucci
mpaulucci reviewed Jan 4, 2024
View reviewed changes
lib/constants.ex Outdated Show resolved Hide resolved
Arkenan
Arkenan previously approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added a couple of style comments.

lib/lambda_ethereum_consensus/p2p/metadata.ex Outdated Show resolved Hide resolved
lib/lambda_ethereum_consensus/p2p/metadata.ex Outdated Show resolved Hide resolved
mpaulucci
mpaulucci previously approved these changes Jan 10, 2024
View reviewed changes
@karasakalmt
Copy link
Contributor Author

@mpaulucci I tried some options to correctly run the CI / Start and stop the node (pull_request) but it doesn't work seems like you have approved with its failure is existing is this something which doesn't need to be fixed?

@mpaulucci
Copy link
Collaborator

@karasakalmt that should work. Have you tried running the node using make checkpoint-sync?

@karasakalmt karasakalmt enabled auto-merge (squash) January 11, 2024 19:22
Arkenan
Arkenan approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karasakalmt karasakalmt merged commit 5c5d333 into lambdaclass:main Jan 12, 2024
10 checks passed
@karasakalmt karasakalmt deleted the feat/ping_metadata branch January 15, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand left review comments

@Arkenan Arkenan Arkenan approved these changes

@mpaulucci mpaulucci mpaulucci left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ping/1 and metadata/2 incoming requests.
4 participants
@karasakalmt @mpaulucci @Arkenan @MegaRedHand