-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ssz write schemas for all containers #520
feat: ssz write schemas for all containers #520
Conversation
{:validators, {:list, SszTypes.Validator, 1_099_511_627_776}}, | ||
{:balances, {:list, {:int, 64}, 1_099_511_627_776}}, | ||
{:randao_mixes, {:list, {:bytes, 32}, 65_536}}, | ||
{:slashings, {:list, {:int, 64}, 8192}}, | ||
{:previous_epoch_participation, {:list, {:int, 8}, 1_099_511_627_776}}, | ||
{:current_epoch_participation, {:list, {:int, 8}, 1_099_511_627_776}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of these constants are in the configuration, so we should grab them from there. For example, 1_099_511_627_776
is VALIDATOR_REGISTRY_LIMIT
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this is not a full review, but I wanted to provide quick feedback and request a way to provide type aliases for less type repetition, and also fix the bytes
apparitions, as they are not ints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR Fernando! I requested some changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some mistakes regarding byte lists. Let's also fix the logs_bloom as you said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
Closes #513