feat: snappy framing format #543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested changes
Jan 2, 2024
|
Also, since CRC-32 checksums seem to be supported by the erlang stdlib, we could add checksum checking in this PR (should be just a call to CRC-32 and a comparison). |
MegaRedHand
reviewed
Jan 3, 2024
Arkenan
requested changes
Jan 5, 2024
There was a problem hiding this comment.
Hello Akash, here are some code quality and bug related comments. They still don't fully fix the problem though. You need to keep debugging. I suggest you do some of the following:
- Check if the masking works. Create a simple 32-bit element, like <<1, 0, 2, 0>>. Think how that would work when masked. That is, follow the rotation and then the addition, by hand (e.g. in a piece of paper). Then, check that your mask function does the same.
- Check with a different implementation, like lighthouse or lodestar, if their implementation of checksums computes the same checksum given the same payload. If they are different we might need to configure something in our crc32 call.
Don't hesitate on printing intermediate results both here and on the other implementation.
Arkenan
requested changes
Jan 11, 2024
Arkenan
requested changes
Jan 17, 2024
MegaRedHand
reviewed
Jan 17, 2024
Comment on lines
+56
to
+79
| # test "decompress Ping responses" do | ||
| # for {msg, expected} <- [ | ||
| # {"0008FF060000734E61507059010C0000B18525A04300000000000000", "4300000000000000"}, | ||
| # {"0008FF060000734E61507059010C00000175DE410100000000000000", "0100000000000000"}, | ||
| # {"0008FF060000734E61507059010C0000EAB2043E0500000000000000", "0500000000000000"}, | ||
| # {"0008FF060000734E61507059010C0000290398070000000000000000", "0000000000000000"} | ||
| # ] do | ||
| # "00" <> "08" <> compressed_payload = msg | ||
| # expected = Base.decode16!(expected) | ||
|
|
||
| # assert_snappy_decompress_frames(compressed_payload, expected) | ||
| # end | ||
|
|
||
| # # Error response | ||
| # msg = | ||
| # "011CFF060000734E6150705900220000EF99F84B1C6C4661696C656420746F20756E636F6D7072657373206D657373616765" | ||
|
|
||
| # "01" <> "1C" <> compressed_payload = msg | ||
|
|
||
| # assert_snappy_decompress_frames( | ||
| # compressed_payload, | ||
| # "Failed to uncompress message" | ||
| # ) | ||
| # end |
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
|
Closing this since Akash is no longer in the bootcamp. Will link this PR to the issue though since there is some good work that has been done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implements the snappy decompression for the framing format.
Closes #224