feat: add some fork choice values to BeaconChain. #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
changed the title
mpaulucci
changed the title
mpaulucci
commented
Jan 11, 2024
MegaRedHand
reviewed
Jan 15, 2024
Comment on lines
+210
to
+212
| #✅ dialyzer: @ Run dialyzer (static analysis tool). | ||
| dialyzer: | ||
| mix dialyzer |
mpaulucci
force-pushed
the
fork-choice-cache
branch
from
3d0066f to
a78db54
Compare
mpaulucci
commented
Jan 18, 2024
Arkenan
approved these changes
Jan 18, 2024
Comment on lines
+22
to
+27
| Application.fetch_env!( | ||
| :lambda_ethereum_consensus, | ||
| __MODULE__ | ||
| )[ | ||
| :implementation | ||
| ] |
There was a problem hiding this comment.
Suggested change
| Application.fetch_env!( | |
| :lambda_ethereum_consensus, | |
| __MODULE__ | |
| )[ | |
| :implementation | |
| ] | |
| Application.fetch_env!( | |
| :lambda_ethereum_consensus, | |
| __MODULE__ | |
| ) | |
| |> Map.fetch!(:implementation) |
Arkenan
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to have to calculate the new head everytime it is requested since it's expensive. Let's store a "cache" (better names welcomed) that gets updated every time we get a new block.
Closes #572