Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement bit list utils module #617

Merged
merged 11 commits into from
Jan 22, 2024
Merged

feat: implement bit list utils module #617

merged 11 commits into from
Jan 22, 2024

Conversation

f3r10
Copy link
Contributor

@f3r10 f3r10 commented Jan 12, 2024

Motivation

Closes #512

@f3r10 f3r10 requested a review from a team as a code owner January 12, 2024 01:09
Arkenan
Arkenan requested changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Requested some changes

test/unit/bit_list_test.exs Show resolved Hide resolved
test/unit/bit_list_test.exs Show resolved Hide resolved
test/unit/bit_list_test.exs Outdated Show resolved Hide resolved
test/unit/bit_list_test.exs Outdated Show resolved Hide resolved
lib/utils/bit_list.ex Outdated Show resolved Hide resolved
lib/utils/bit_list.ex Outdated Show resolved Hide resolved
@f3r10 f3r10 requested a review from Arkenan January 15, 2024 12:23
Arkenan
Arkenan previously approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some changes. Feel free to apply them and merge afterwards.

lib/utils/bit_list.ex Outdated Show resolved Hide resolved
lib/utils/bit_field.ex Outdated Show resolved Hide resolved
lib/utils/bit_field.ex Outdated Show resolved Hide resolved
lib/utils/bit_field.ex Outdated Show resolved Hide resolved
@f3r10 f3r10 requested review from Arkenan January 17, 2024 11:54
Arkenan
Arkenan approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@Arkenan Arkenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkenan Arkenan merged commit 6eeaba3 into lambdaclass:main Jan 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkenan Arkenan Awaiting requested review from Arkenan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bitlist utils
2 participants
@f3r10 @Arkenan