Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optimization on merkleization of chunks by precomputed hashes #644

Merged
merged 31 commits into from
Jan 29, 2024
Merged

feat: optimization on merkleization of chunks by precomputed hashes #644

merged 31 commits into from
Jan 29, 2024

Conversation

Godspower-Eze
Copy link
Contributor

@Godspower-Eze Godspower-Eze commented Jan 17, 2024 •
edited
Loading

Outcome

##### With input args #####
Name                                                  ips        average  deviation         median         99th %
SszEx.merkleize_chunks_with_virtual_padding       73.71 K       13.57 μs    ±49.03%       12.42 μs       44.17 μs
SszEx.merkleize_chunks                            20.48 K       48.83 μs    ±35.14%       49.63 μs       65.63 μs

Comparison: 
SszEx.merkleize_chunks_with_virtual_padding       73.71 K
SszEx.merkleize_chunks                            20.48 K - 3.60x slower +35.26 μs

Closes #597

@Godspower-Eze Godspower-Eze requested a review from a team as a code owner January 17, 2024 07:56
@Godspower-Eze Godspower-Eze marked this pull request as draft January 17, 2024 07:56
@Godspower-Eze Godspower-Eze marked this pull request as ready for review January 22, 2024 23:07
MegaRedHand
MegaRedHand reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work!

lib/ssz_ex.ex Outdated Show resolved Hide resolved
lib/ssz_ex.ex Outdated Show resolved Hide resolved
lib/ssz_ex.ex Outdated Show resolved Hide resolved
lib/ssz_ex.ex Outdated Show resolved Hide resolved
lib/ssz_ex.ex Outdated Show resolved Hide resolved
MegaRedHand
MegaRedHand reviewed Jan 24, 2024
View reviewed changes
lib/ssz_ex.ex Outdated Show resolved Hide resolved
@mpaulucci mpaulucci mentioned this pull request Jan 29, 2024
Merged
mpaulucci
mpaulucci reviewed Jan 29, 2024
View reviewed changes
lib/utils/zero_hashes.ex Outdated Show resolved Hide resolved
@mpaulucci mpaulucci merged commit 181ac77 into lambdaclass:main Jan 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand left review comments

@mpaulucci mpaulucci mpaulucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SSZ] Optimization on merkleization of chunks by precomputed hashes.
3 participants
@Godspower-Eze @mpaulucci @MegaRedHand