Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make beacon API port configurable #901

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Conversation

avilagaston9
Copy link
Contributor

Motivation

This PR allows configuring the port that serves the Beacon API

Description

This PR adds the --beacon-api-port <PORT> flag, which accepts the port serving the Beacon API, allowing multiple nodes to run on each port.

Closes #811

@avilagaston9 avilagaston9 linked an issue Mar 20, 2024 that may be closed by this pull request
@avilagaston9 avilagaston9 changed the title Make beacon API port configurable feat: Make beacon API port configurable Mar 20, 2024
@avilagaston9 avilagaston9 changed the title feat: Make beacon API port configurable feat: make beacon API port configurable Mar 20, 2024
config/runtime.exs Outdated Show resolved Hide resolved
@avilagaston9 avilagaston9 marked this pull request as ready for review March 20, 2024 18:43
@avilagaston9 avilagaston9 requested a review from a team as a code owner March 20, 2024 18:43
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Congrats on your first contribution 🥳

@MegaRedHand MegaRedHand enabled auto-merge (squash) March 20, 2024 20:23
@MegaRedHand MegaRedHand merged commit 8c58b17 into main Mar 20, 2024
12 checks passed
@MegaRedHand MegaRedHand deleted the configurable_api_port branch March 20, 2024 20:23
@MegaRedHand
Copy link
Collaborator

@all-contributors please add @avilagaston9 for code

Copy link
Contributor

@MegaRedHand

I've put up a pull request to add @avilagaston9! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Allow configuring the port which serves the Beacon API
2 participants