Fixes #10
Closed
Fixes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azteca1998
reviewed
Sep 18, 2024
Comment on lines
+91
to
+92
|
|
||
|
|
There was a problem hiding this comment.
This wouldn't pass a formatting check.
Comment on lines
+104
to
+111
| let const_field_type = match &field_type { | ||
| CoreTypeConcrete::Const(inner) => inner, | ||
| _ => unreachable!(), | ||
| }; | ||
|
|
||
| let field_value = | ||
| inner(registry, &const_field_type.inner_ty, &const_field_type.inner_data); | ||
| fields.push(field_value); |
There was a problem hiding this comment.
What's the difference between this and the previous code? Why is this better?
Comment on lines
+59
to
+70
| // Copied from the sierra to casm lowering | ||
| // NonZero is the same type as the inner type in native. | ||
| [GenericArg::Type(inner_ty)] => { | ||
| let inner_type = registry.get_type(inner_ty).unwrap(); | ||
| let const_inner_type = match inner_type { | ||
| CoreTypeConcrete::Const(inner) => inner, | ||
| _ => unreachable!(), | ||
| }; | ||
|
|
||
| inner(registry, &const_inner_type.inner_ty, &const_inner_type.inner_data) | ||
| } | ||
| _ => unreachable!(), |
There was a problem hiding this comment.
Why can't it just recursively call inner?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.