-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement circuits. #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Work @FrancoGiachetta!! I left you a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FrancoGiachetta I left you some comments I missed in my first review
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example I gave in the previous review is still failing:
let a = outputs.get_output(mul);
let b = a.limb1;
drop(b)
This is due to the bad BoundedInt range. Remember to test it again after fixing a bug, just to make sure!
Also, once you fix this, I recommend that you manually test the implementation with a more complex scenario, just to make sure it works. As an example, you can use this test from Cairo Native: https://github.com/lambdaclass/cairo_native/blob/8ee32eb38f1c86598033e493b2908cfb648b9205/src/libfuncs/circuit.rs#L1351
Everything should be working now. I added the test you were taking about. I also downloaded the corelib so we can test the programs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You included Cairo 2.7.0 in the PR. I don't think it should be here.
Isn't it required to be able to compile .cairo files? So we can test cairo programs which are not contracts. |
Sure, but not in our repository. Just add a dependency. If we need the binary we can replicate what we do in native (aka. |
Oh, I see. I'll remove it then |
Done! |
No description provided.