Refactor execution functions with proper error handling #107
+163
−314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGCalderon
force-pushed
the
remove-unwraps
branch
from
a2a115b to
a97f8e3
Compare
JulianGCalderon
force-pushed
the
remove-unwraps
branch
from
684bf06 to
da146b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99, #84, #18
Supersedes #19
This PR refactors the execution functions to make them easier to user, and adds proper error handling. I replaced the old functions with 2 new functions:
execute_transaction: Executes a single transaction with a clean state, fetching all needed information.fetch_transaction: Fetches all information needed to execute a transaction.The github diff is not useful for reviewing the changes as they have a lot of overlap. I'd suggest reviewing it with an external editor, as the whole
execution.rsfile has been changed.