Use tx current block in tests #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGCalderon
requested review from
edg-l,
igaray,
azteca1998,
fmoletta and
pefontana
as code owners
pefontana
requested changes
Jul 6, 2024
| RpcChain::MainNet | ||
| => ignore | ||
| )] | ||
| fn blockifier_tx(hash: &str, block_number: u64, chain: RpcChain) { | ||
| // Execute using blockifier | ||
| let (tx_info, trace, _receipt) = execute_tx(hash, chain, BlockNumber(block_number)); | ||
| let (tx_info, trace, _receipt) = execute_tx(hash, chain, BlockNumber(block_number - 1)); |
There was a problem hiding this comment.
Document this line explaining the -1
JulianGCalderon
force-pushed
the
use-tx-current-block
branch
from
0bddd2f to
d0b001e
Compare
pefontana
approved these changes
Jul 15, 2024
edg-l
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the tests so that they have the current transaction block in the test case, instead of the previous one