Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add events and messages checks #30

Closed
wants to merge 8 commits into from
Closed

Add events and messages checks #30

wants to merge 8 commits into from

Conversation

FrancoGiachetta
Copy link
Contributor

Refers to #26
This PR adds assertions related to the messages and event generated during the execution of the tx.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

✅ Code is now correctly formatted.

@FrancoGiachetta FrancoGiachetta force-pushed the add_events_messages_checks branch from 80fc1bb to 3f72820 Compare July 10, 2024 15:39
@FrancoGiachetta FrancoGiachetta marked this pull request as ready for review July 10, 2024 15:44
JulianGCalderon
JulianGCalderon requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@JulianGCalderon JulianGCalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new checks made some tests to stop working, can you mark them as ignored? you can put a meaningful message such as: events mismatch

@FrancoGiachetta
Copy link
Contributor Author

Those tests are being ignored now

@pefontana
Copy link
Collaborator

This is done correctly in #35

@pefontana pefontana closed this Aug 12, 2024
@pefontana pefontana deleted the add_events_messages_checks branch August 12, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianGCalderon JulianGCalderon JulianGCalderon approved these changes

@edg-l edg-l Awaiting requested review from edg-l edg-l is a code owner

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@azteca1998 azteca1998 Awaiting requested review from azteca1998 azteca1998 is a code owner

@fmoletta fmoletta Awaiting requested review from fmoletta fmoletta is a code owner

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrancoGiachetta @pefontana @JulianGCalderon