Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: std requires alloc #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: std requires alloc #7

wants to merge 2 commits into from

Conversation

Oppen
Copy link

@Oppen Oppen commented Dec 20, 2023

The Rust standard library already requires a global allocator. This means all features that only depend on that should be usable when std is enabled, so let's make that implication explicit in our manifest.

Pull Request type

  • Bugfix

What is the current behavior?

You need to explicitly enable alloc even if you're building with std.

What is the new behavior?

Enabling std always enables alloc.

Does this introduce a breaking change?

Technically, yes. You can no longer trigger a build with std but no global allocator. In practice, no, those builds were already broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants