Fix serialization of pydantic.BaseModel fields with pathlib.Path dict keys
#1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for flagging and proposing a fix! Do you have an example test case you could add? :) |
brendanator
commented
Oct 31, 2024
| elif hasattr(obj, "dict") and callable(obj.dict): | ||
| return obj.dict() | ||
| elif hasattr(obj, "_asdict") and callable(obj._asdict): | ||
| return obj._asdict() |
There was a problem hiding this comment.
removed these are they are dead code - namedtuple, and pydantic.BaseModel are handled in _serialize_json
brendanator
changed the title
pydantic.BaseModel fields with pathlib.Path dict keys
brendanator
commented
Oct 31, 2024
| ("to_dict", False), # dataclasses-json | ||
| ( | ||
| "model_dump", | ||
| {"exclude_none": True, "mode": "json"}, |
There was a problem hiding this comment.
mode="json" convert pathlib.Path dict keys to str
brendanator
commented
Oct 31, 2024
Apply `_simple_default` serialization on dict keys to resolve this exception
```python
Traceback (most recent call last):
File "/Users/brendan/.local/share/virtualenvs/core-bRkH1-KB/lib/python3.11/site-packages/langsmith/client.py", line 281, in _dumps_json_single
return orjson.dumps(
^^^^^^^^^^^^^
TypeError: Dict key must a type serializable with OPT_NON_STR_KEYS
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/brendan/.local/share/virtualenvs/core-bRkH1-KB/lib/python3.11/site-packages/langsmith/client.py", line 5802, in _tracing_thread_handle_batch
client.multipart_ingest_runs(create=create, update=update, pre_sampled=True)
File "/Users/brendan/.local/share/virtualenvs/core-bRkH1-KB/lib/python3.11/site-packages/langsmith/client.py", line 1675, in multipart_ingest_runs
valb = _dumps_json(value)
^^^^^^^^^^^^^^^^^^
File "/Users/brendan/.local/share/virtualenvs/core-bRkH1-KB/lib/python3.11/site-packages/langsmith/client.py", line 321, in _dumps_json
return _dumps_json_single(obj, _serialize_json)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/brendan/.local/share/virtualenvs/core-bRkH1-KB/lib/python3.11/site-packages/langsmith/client.py", line 292, in _dumps_json_single
result = json.dumps(
^^^^^^^^^^^
File "/usr/local/Cellar/python@3.11/3.11.10/Frameworks/Python.framework/Versions/3.11/lib/python3.11/json/__init__.py", line 238, in dumps
**kw).encode(obj)
^^^^^^^^^^^
File "/usr/local/Cellar/python@3.11/3.11.10/Frameworks/Python.framework/Versions/3.11/lib/python3.11/json/encoder.py", line 200, in encode
chunks = self.iterencode(o, _one_shot=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/Cellar/python@3.11/3.11.10/Frameworks/Python.framework/Versions/3.11/lib/python3.11/json/encoder.py", line 258, in iterencode
return _iterencode(o, 0)
^^^^^^^^^^^^^^^^^
TypeError: keys must be str, int, float, bool or None, not PosixPath
```
|
@hinthornw Added test cases, and then cleaned up my implementation |
|
@hinthornw Is there anything I need to do to get this in? Happy to make any follow up changes you want |
|
I've merged latest main and updated the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply
_simple_defaultserialization on dict keys to resolve this exception