Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use AsyncSession in memory #4665

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Nov 18, 2024

Use AsyncSession in memory

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 18, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 18, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cbornet

Have you checked the ComponentTestBase(

class TestChatInput(ComponentTestBaseWithClient):
)?

Maybe we can build these for the components you've changed to make sure they don't break in future releases.

Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #4665 will degrade performances by 15.38%

Comparing cbornet:async-memory-2 (ccc8ddc) with main (3188517)

Summary

⚡ 3 improvements
❌ 1 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cbornet:async-memory-2 Change
test_successful_run_with_input_type_any 219.5 ms 192.4 ms +14.1%
test_successful_run_with_input_type_text 217.6 ms 175.5 ms +24%
test_successful_run_with_output_type_any 271.2 ms 320.5 ms -15.38%
test_successful_run_with_output_type_debug 295.5 ms 238.4 ms +23.96%

@cbornet
Copy link
Collaborator Author

cbornet commented Nov 18, 2024

@ogabrielluiz I fixed TestChatInput. Can you check again ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants