Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve waiting logic in playground.spec.ts #4672

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −26
Open

fix: Improve waiting logic in playground.spec.ts #4672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 30 additions & 26 deletions src/frontend/tests/core/features/playground.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ test("fresh start playground", async ({ page }) => {

while (modalCount === 0) {
await page.getByText("New Flow", { exact: true }).click();
await page.waitForTimeout(3000);
await page.waitForSelector('[data-testid="modal-title"]', {
timeout: 3000,
});
modalCount = await page.getByTestId("modal-title")?.count();
}

Expand All @@ -41,7 +43,9 @@ test("fresh start playground", async ({ page }) => {

await page.getByTestId("sidebar-search-input").click();
await page.getByTestId("sidebar-search-input").fill("chat output");
await page.waitForTimeout(1000);
await page.waitForSelector('[data-testid="outputsChat Output"]', {
timeout: 1000,
});

await page
.getByTestId("outputsChat Output")
Expand All @@ -60,7 +64,9 @@ test("fresh start playground", async ({ page }) => {

await page.getByTestId("sidebar-search-input").click();
await page.getByTestId("sidebar-search-input").fill("chat input");
await page.waitForTimeout(1000);
await page.waitForSelector('[data-testid="inputsChat Input"]', {
timeout: 1000,
});

await page
.getByTestId("inputsChat Input")
Expand All @@ -74,7 +80,9 @@ test("fresh start playground", async ({ page }) => {

await page.getByTestId("sidebar-search-input").click();
await page.getByTestId("sidebar-search-input").fill("text output");
await page.waitForTimeout(1000);
await page.waitForSelector('[data-testid="outputsText Output"]', {
timeout: 1000,
});

await page
.getByTestId("outputsText Output")
Expand Down Expand Up @@ -191,7 +199,9 @@ test("fresh start playground", async ({ page }) => {
.filter({ hasText: /^Usermessage 1$/ })
.getByTestId("icon-Pen")
.click();
await page.waitForTimeout(500);
await page.waitForSelector('[data-testid="textarea"]', {
timeout: 500,
});

await page.getByTestId("textarea").fill("edit_1");
await page.getByTestId("save-button").click();
Expand All @@ -200,8 +210,9 @@ test("fresh start playground", async ({ page }) => {
// check cancel edit
await page.getByTestId("sender_name_user").hover();
await page.getByTestId("icon-Pen").first().click();
await page.waitForTimeout(500);

await page.waitForSelector('[data-testid="textarea"]', {
timeout: 500,
});
await page.getByTestId("textarea").fill("cancel_edit");
await page.getByTestId("cancel-button").click();
await page.getByTestId("chat-message-User-edit_1").click();
Expand All @@ -213,15 +224,19 @@ test("fresh start playground", async ({ page }) => {
.click();
await page.getByTestId("chat-message-AI-message 1").hover();
await page.getByTestId("icon-Pen").last().click();
await page.waitForTimeout(500);
await page.waitForSelector('[data-testid="textarea"]', {
timeout: 500,
});

await page.getByTestId("textarea").fill("edit_bot_1");
await page.getByTestId("save-button").click();
await page.getByText("edit_bot_1").click();
// check cancel edit bot
await page.getByTestId("chat-message-AI-edit_bot_1").hover();
await page.getByTestId("icon-Pen").last().click();
await page.waitForTimeout(500);
await page.waitForSelector('[data-testid="textarea"]', {
timeout: 500,
});

await page.getByTestId("textarea").fill("edit_bot_cancel");
await page.getByTestId("cancel-button").click();
Expand All @@ -236,7 +251,9 @@ test("fresh start playground", async ({ page }) => {
await page.getByLabel("Rename").getByText("Rename").click();
await page.getByRole("textbox").fill("new name");
await page.getByTestId("icon-Check").click();
await page.waitForTimeout(500);
await page.waitForSelector('[data-testid="session-selector"]', {
timeout: 500,
});

await page.getByTestId("session-selector").getByText("new name").click();
// check cancel rename
Expand Down Expand Up @@ -264,20 +281,7 @@ test("fresh start playground", async ({ page }) => {

// check new chat
await page.getByTestId("new-chat").click();
await page.waitForTimeout(5000);
await page.getByText("New chat").click();
await page.getByTestId("input-chat-playground").click();
await page.getByTestId("input-chat-playground").fill("second session");
await page.keyboard.press("Enter");
await page.waitForTimeout(5000);

await page.getByTestId("chat-message-User-second session").click();
await page
.getByTestId("chat-message-AI-second session")
.getByText("second session")
.click();
expect(await page.getByTestId("session-selector").count()).toBe(2);

const sessionElements = await page.getByTestId("session-selector").all();
expect(sessionElements.length).toBe(2);
await page.waitForSelector('text="New chat"', {
timeout: 5000,
Comment on lines +284 to +285
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the rest of this test?

});
});
Loading