Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use AsyncSession in crud log and find_flow #4691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Nov 18, 2024

Use AsyncSession in crud log

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 18, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 18, 2024
@cbornet cbornet changed the title fix: Use AsyncSession in crud log fix: Use AsyncSession in crud log and find_flow Nov 18, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 18, 2024
@cbornet cbornet force-pushed the async-session-crud-log branch 2 times, most recently from 2f4eadc to 523696f Compare November 19, 2024 10:33
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 19, 2024
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #4691 will degrade performances by 37.38%

Comparing cbornet:async-session-crud-log (52863e3) with main (a0acf39)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cbornet:async-session-crud-log Change
test_invalid_run_with_input_type_chat 27 ms 32.6 ms -17.1%
test_successful_run_with_input_type_any 298.1 ms 247.2 ms +20.59%
test_successful_run_with_output_type_any 141.1 ms 225.3 ms -37.38%

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Nov 19, 2024
@cbornet cbornet force-pushed the async-session-crud-log branch 3 times, most recently from f81180a to 15e2efc Compare November 20, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant