ref: Remove usage of deprecated get_event_loop #4697
+56
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
CodSpeed Performance ReportMerging #4697 will improve performances by 56.75%Comparing Summary
Benchmarks breakdown
|
cbornet
commented
Nov 19, 2024
| if loop.is_running(): | ||
| # Run the coroutine in a separate event loop in a new thread | ||
| return run_in_thread(coro) | ||
| return loop.run_until_complete(coro) |
There was a problem hiding this comment.
If the loop is not running, this will most probably not work.
cbornet
commented
Nov 19, 2024
|
|
||
|
|
||
| def run_until_complete(coro): | ||
| try: | ||
| loop = asyncio.get_event_loop() | ||
| if loop.is_running(): | ||
| # Run the coroutine in a separate event loop in a new thread |
There was a problem hiding this comment.
What is the advantage of running in a separate thread+loop ?
There was a problem hiding this comment.
I can't remember. Maybe related to the this event loop is already running error.
ogabrielluiz
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of deprecated get_event_loop