Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Apply ruff rules preview autofix #4699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ref: Apply ruff rules preview autofix #4699

wants to merge 1 commit into from
+34 −34

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Nov 19, 2024

Apply ruff rules preview autofix

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 19, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #4699 will degrade performances by 52.9%

Comparing cbornet:ruff-rules-preview-5 (81cc71a) with main (699ec18)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cbornet:ruff-rules-preview-5 Change
⚡ test_successful_run_with_input_type_any 298.5 ms 219.3 ms +36.13%
❌ test_successful_run_with_output_type_any 232.6 ms 272.2 ms -14.56%
❌ test_successful_run_with_output_type_debug 139.1 ms 295.3 ms -52.9%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cbornet