Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12448 - update bedrock retrieve tool, support hybrid search type and re… #12446

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Fix #12448 - update bedrock retrieve tool, support hybrid search type and re… #12446

merged 4 commits into from
Jan 7, 2025

Conversation

ybalbert001
Copy link
Contributor

@ybalbert001 ybalbert001 commented Jan 7, 2025 •
edited by crazywoola
Loading

…rank model

Summary

Close #12448

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Jan 7, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jan 7, 2025
@ybalbert001 ybalbert001 changed the title [Fix] update bedrock retrieve tool, support hybrid search type and re… Fix #12448 - update bedrock retrieve tool, support hybrid search type and re… Jan 7, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 7, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 7, 2025
@crazywoola crazywoola merged commit 2a14c67 into langgenius:main Jan 7, 2025
5 checks passed
@laipz8200 laipz8200 mentioned this pull request Jan 13, 2025
Merged
alexcodelf pushed a commit to alexcodelf/dify that referenced this pull request Jan 21, 2025
@ybalbert001 @alexcodelf
Fix langgenius#12448 - update bedrock retrieve tool, support hybrid s…
0eaa8a5 
…earch type and re… (langgenius#12446)

Co-authored-by: Yuanbo Li <ybalbert@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bedrock knowledge base] Can't use hybrid search and rerank model
2 participants
@ybalbert001 @crazywoola