Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support redis sentinel mode #7756

Merged
merged 4 commits into from
Sep 8, 2024
Merged

feat: support redis sentinel mode #7756

merged 4 commits into from
Sep 8, 2024

Conversation

erigo
Copy link
Contributor

@erigo erigo commented Aug 28, 2024 •
edited
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Ref: Close #7632

  1. Support connecting to Redis shards via Redis Sentinel.
  2. Celery broker_url support Redis Sentinel.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request labels Aug 28, 2024
@erigo erigo mentioned this pull request Aug 28, 2024
Closed
12 tasks
@crazywoola
Copy link
Member

Hello, thanks for this PR, please update the environment sections here as well in this repo https://github.com/langgenius/dify-docs.

@erigo
Copy link
Contributor Author

erigo commented Aug 28, 2024

Hello, thanks for this PR, please update the environment sections here as well in this repo https://github.com/langgenius/dify-docs.

OK，👌

@erigo
Copy link
Contributor Author

erigo commented Aug 28, 2024

See: langgenius/dify-docs#236

@erigo
Copy link
Contributor Author

erigo commented Aug 30, 2024

@crazywoola Is there anything else that needs to be addressed in this PR? 😄

@crazywoola
Copy link
Member

crazywoola commented Sep 4, 2024 •
edited
Loading

@crazywoola Is there anything else that needs to be addressed in this PR? 😄

Please update the en_US and ja_JP as well. @erigo

https://github.com/langgenius/dify-docs/pull/236/files

crazywoola
crazywoola approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2024
@erigo
Copy link
Contributor Author

erigo commented Sep 5, 2024

@crazywoola Is there anything else that needs to be addressed in this PR? 😄

Please update the en_US and ja_JP as well. @erigo

https://github.com/langgenius/dify-docs/pull/236/files

OK

@erigo erigo mentioned this pull request Sep 6, 2024
Merged
@erigo
Copy link
Contributor Author

erigo commented Sep 6, 2024 •
edited
Loading

@crazywoola TBR 🙏

@erigo erigo requested a review from crazywoola September 6, 2024 12:07
@crazywoola crazywoola self-assigned this Sep 7, 2024
@crazywoola crazywoola merged commit d542b15 into langgenius:main Sep 8, 2024
6 checks passed
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
@erigo @cuiks
feat: support redis sentinel mode (langgenius#7756)
4714e92
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@erigo @lau-td
feat: support redis sentinel mode (langgenius#7756)
b747e92
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@erigo @JunXu01
feat: support redis sentinel mode (langgenius#7756)
a93ebad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola Awaiting requested review from crazywoola

Assignees

@crazywoola crazywoola

Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Redis Sentinel connection
2 participants
@erigo @crazywoola