Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #8071] set step to 1 for int and 0.1 for float in input component #8072

Closed
wants to merge 3 commits into from

Conversation

AAEE86
Copy link
Contributor

@AAEE86 AAEE86 commented Sep 6, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Sep 6, 2024
@AAEE86 AAEE86 mentioned this pull request Sep 6, 2024
12 tasks
@AAEE86 AAEE86 changed the title Fix: set step to 1 for int and 0.1 for float in input component [Issue #8071] set step to 1 for int and 0.1 for float in input component Sep 6, 2024
@AAEE86
Copy link
Contributor Author

AAEE86 commented Sep 6, 2024

Fixes #8071

else if (parameterRule.max < 10000)
step = 100
}
const step = parameterRule.type === 'int' ? 1 : 0.1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines should not be removed, I think there should be a better way to do this.

@crazywoola crazywoola closed this Sep 7, 2024
@AAEE86 AAEE86 deleted the patch-1 branch September 7, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants