Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing models from Voyage #8950

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

CXwudi
Copy link
Contributor

@CXwudi CXwudi commented Sep 30, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (no code changes)
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods (no code changes)

Description

Simply just added more models from Voyage. Specifically, the newest rerank models rerank-2 and rerank-2-lite from Voyage. I also added other domain-specific embedding models from Voyage.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Make sure they are choosable (Unfortunately, I couldn't make the embedding process working in the dev container setup. Hence, I can't really check if my changes really work. But since I only added the YAML file and I followed the format. I think it should work seamlessly.)

Screenshot 2024-09-30 172544
Screenshot 2024-09-30 172802

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ⚙️ feat:model-runtime labels Sep 30, 2024
@CXwudi CXwudi changed the title chore: add missing models for voyage chore: add missing models from Voyage Sep 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 1, 2024
@crazywoola crazywoola merged commit cdd7e55 into langgenius:main Oct 1, 2024
6 checks passed
@CXwudi CXwudi deleted the feat/newest-voyage-models branch October 1, 2024 04:10
aloababa pushed a commit to iguanesolutions/dify that referenced this pull request Oct 2, 2024
cuiks pushed a commit to cuiks/dify that referenced this pull request Oct 8, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants