Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add allow_llm_to_see_data flag for vanna #9156

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

hwzhuhao
Copy link
Contributor

@hwzhuhao hwzhuhao commented Oct 10, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  1. add allow_llm_to_see_data flag for vanna
  2. remove generate_chart flag just as the pr fix: vanna CVE-2024-5565 by disable visualize of ask func #4930
  3. bump vanna version to 0.7.3

image

Fixes #8989

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request 🔨 feat:tools Tools for agent, function call related stuff. labels Oct 10, 2024
@hwzhuhao hwzhuhao force-pushed the feat/vanna branch 2 times, most recently from 792d9af to fffaaf8 Compare October 10, 2024 07:42
Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @laipz8200

crazywoola
crazywoola previously approved these changes Oct 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 10, 2024
@crazywoola crazywoola merged commit 05c1ef7 into langgenius:main Oct 10, 2024
6 checks passed
@hwzhuhao hwzhuhao deleted the feat/vanna branch October 13, 2024 13:28
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request 🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vanna AI Customization for better SQL execution
3 participants