Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: Refresh updated_at field of DataSourceOauthBinding model #9173

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

sunxiaoguang
Copy link
Contributor

@sunxiaoguang sunxiaoguang commented Oct 10, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

We expect to refresh updated_at field of DataSourceOauthBinding, like it is in api/controllers/console/datasets/data_source.py:75. This PR tries to add this logic in api\libs\oauth_data_source.py.

Fixes #9172

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 📚 feat:datasource Data sources like web, Notion, Logseq, Lark, Docs labels Oct 10, 2024
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@sunxiaoguang sunxiaoguang changed the title Refresh updated_at field of DataSourceOauthBinding model [improve]: Refresh updated_at field of DataSourceOauthBinding model Oct 10, 2024
@sunxiaoguang sunxiaoguang changed the title [improve]: Refresh updated_at field of DataSourceOauthBinding model improve: Refresh updated_at field of DataSourceOauthBinding model Oct 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 10, 2024
@JohnJyong JohnJyong merged commit be2f1e5 into langgenius:main Oct 10, 2024
6 checks passed
@sunxiaoguang sunxiaoguang deleted the refresh_updated_at branch October 10, 2024 09:21
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 feat:datasource Data sources like web, Notion, Logseq, Lark, Docs lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updated_at field of DataSourceOauthBinding is not refreshed in some places
2 participants