Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tools): Refactor the base table plugin #9182

Merged
merged 11 commits into from
Oct 22, 2024

Conversation

hgnulb
Copy link

@hgnulb hgnulb commented Oct 10, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Made some optimizations to the multidimensional table plugin.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

image

img_v3_02fh_2438e9eb-c1aa-42a4-a84f-51d94d228dbg

@hgnulb hgnulb force-pushed the feature/update_feishu_base_tools branch from d4dd51f to 5ab56dd Compare October 10, 2024 10:52
@hgnulb hgnulb force-pushed the feature/update_feishu_base_tools branch from c633722 to ab91f89 Compare October 10, 2024 10:54
@hgnulb hgnulb marked this pull request as ready for review October 12, 2024 02:58
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Oct 12, 2024
@hgnulb
Copy link
Author

hgnulb commented Oct 17, 2024

@crazywoola Hello, could you help me with a review?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 22, 2024
@crazywoola crazywoola merged commit a9db06f into langgenius:main Oct 22, 2024
6 checks passed
@crazywoola
Copy link
Member

Approved

@WUXM5
Copy link

WUXM5 commented Nov 3, 2024

Sorry to bother you, I encountered an issue where the filtering function of the multi-dimensional table is not working.
I debugged it normally in the Feishu backend, but when applying the filter in the Feishu multi-dimensional table, it runs successfully, but does not take effect.

@hgnulb hgnulb deleted the feature/update_feishu_base_tools branch November 11, 2024 06:33
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Co-authored-by: 黎斌 <libin.23@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants