Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log list): prevent duplicate data fetch #9190

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Oct 10, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Ensure data is fetched only once by tracking fetch initiation with a useRef hook. This avoids unnecessary repeated network calls when conditions are met, improving efficiency and performance.

image

Fixes #9189

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Ensure data is fetched only once by tracking fetch initiation with a useRef hook. This avoids unnecessary repeated network calls when conditions are met, improving efficiency and performance.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Oct 10, 2024
@laipz8200 laipz8200 requested a review from JzoNgKVO October 10, 2024 19:12
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 11, 2024
@crazywoola crazywoola merged commit a348918 into main Oct 11, 2024
7 checks passed
@crazywoola crazywoola deleted the fix/prevent-duplicate-data-fetch branch October 11, 2024 02:32
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Requests and Message Display in Firefox Browser
2 participants