[pt] Moved rule verbs/nouns down and improved it disambiguation.xml

[marcoagpinto]

I noticed that the verb/noun rules, some of them, need to be moved down to fully work.

So, I have moved it down and improved it.

Summary by CodeRabbit

• New Features
  • Introduced a new grammar rule for Portuguese to improve verb disambiguation, specifically targeting infinitive forms followed by nouns.
• Documentation
  • Added comments to clarify the functionality of specific grammar rules.

[coderabbitai]

Walkthrough

The pull request introduces a new rule in the disambiguation.xml file for Portuguese grammar rules in LanguageTool. The new rule, identified as PI_VERBS, is designed to prevent certain patterns involving infinitive verbs followed by specific nouns from being incorrectly tagged as verbs. Additionally, the update includes comments to clarify the functionality of existing rules, while maintaining the overall structure of the file without removing any existing rules.

Changes

File	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml	Added new rule <rule id="PI_VERBS" name="Remove PI.+ followed by noun from appearing as verb"> and included comments for clarification.

Possibly related PRs

• [pt] Fixed tons of FPs "nouns -> verbs" in disambiguation.xml #10926: Modifies disambiguation.xml to enhance disambiguation rules for Portuguese, related to the new rule added in this PR.
• [pt] Major improvement in verbs/nouns in disambiguation.xml rule ID:RARE_POS #10986: Updates the RARE_POS rule in disambiguation.xml, directly connected to the new verb disambiguation rule.
• [pt] Major fix in verbs/nouns detection in disambiguation.xml #10991: Introduces a new rule in disambiguation.xml that enhances verb and noun handling, relevant to the changes in the main PR.
• [pt] Fix for "ela o ama" in disambiguation.xml rule ID:RARE_POS #10993: Addresses issues in disambiguation.xml related to verb and noun classification, connecting to the new rule added.
• [pt] Verb/noun improvements (pela/como) in disambiguation.xml #11003: Adds a new rule in the RARE_POS group of disambiguation.xml, relevant to the focus on verb disambiguation.
• [pt] Improved even more the verbs/nouns rule in disambiguation.xml, rule ID:RARE_POS #11004: Improves the RARE_POS rule in disambiguation.xml, directly related to the new rule added in this PR.
• [pt] Had to move rule down for it to work with adverbs (RM) #11006: Introduces a new rule in disambiguation.xml for handling certain verbs, relevant to the changes made in the main PR.

Suggested reviewers

• jaumeortola

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 680c856 and 3a07ceb.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (2 hunks)

🔇 Additional comments (2)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (2)

257-257: LGTM! Clear documentation of rule relocation.

The comment effectively documents the movement of PI.+ rules to the bottom of the file, providing good context for the code organization change.

---

3843-3857: Well-structured rule with clear documentation.

The new PI_VERBS rule is well-implemented with:

• Clear purpose documentation
• Proper exception handling
• Specific verb form targeting
• Thoughtful exclusion of VMP00SM to maintain compatibility

The rule effectively prevents incorrect verb tagging when followed by nouns, improving disambiguation accuracy.

Let's verify the impact of this rule on the codebase:

✅ Verification successful

Based on the search results, I can now verify the review comment. The search shows that:

1. The new PI_VERBS rule is well-positioned in the Portuguese disambiguation rules
2. The verb forms (VMIP3S0, VMM02S0, etc.) are consistently used across multiple language modules
3. The rule's pattern matches common verb-noun disambiguation patterns seen in other rules
4. The removal of VMP00SM to avoid breaking Premium is consistent with the codebase's approach

Rule implementation is correct and safe.

The rule:

• Uses standard verb form tags (VMIP3S0, VMM02S0, etc.) that are well-established in the codebase
• Follows the pattern of other disambiguation rules that handle verb-noun ambiguity
• Properly handles exceptions with postag_regexp
• Has a clear purpose and documentation
• Takes precautions to maintain Premium compatibility

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for potential conflicts with the new PI_VERBS rule

# Test 1: Look for similar patterns that might be affected
rg -A 2 'postag="VMIP3S0|VMM02S0|VMSP2S0|VMIP2S0|VMN02S0|VMSF2S0|VMIP1S0"'

# Test 2: Check for any existing rules that might conflict with PI_VERBS
rg -A 2 'token postag="NC\.\+" postag_regexp="yes"'

Length of output: 167455

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.