Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified GUFI driver and added Test #32

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Modified GUFI driver and added Test #32

merged 2 commits into from
Jun 22, 2023

Conversation

hugegreenbug
Copy link
Collaborator

Changed GUFI driver to use the new FsStore abstract class
Changed the GUFI query command to use a dsi db, dsi db table, and a dsi db column for joining with GUFI metadata
Added a GUFI test

Changed the GUFI query command to use a dsi db, dsi db table, and a dsi db column for joining with GUFI metadata
Added a GUFI test
@qwofford
Copy link
Collaborator

This brings up a good question. How do we handle plugin and driver testing if plugins and drivers are compiled tools? I opened #33 to track this concern, but resolution is not required for merging this PR. Just pick a new path prefix in test_gufi.py for now

@qwofford
Copy link
Collaborator

Looks good to me:

$ pytest -v
============================= test session starts ==============================
platform linux -- Python 3.11.3, pytest-7.3.2, pluggy-1.0.0 -- ~/miniconda3/envs/dsi/bin/python
cachedir: .pytest_cache
rootdir: <ROOT DIR>
collected 14 items                                                             

dsi/drivers/filesystem/tests/test_gufi.py::test_query PASSED             [  7%]
dsi/drivers/filesystem/tests/test_gufi.py::test_artifact_query PASSED    [ 14%]
dsi/drivers/filesystem/tests/test_sqlite.py::test_wildfire_data_sql_artifact PASSED [ 21%]
dsi/drivers/filesystem/tests/test_sqlite.py::test_wildfire_data_csv_artifact PASSED [ 28%]
dsi/drivers/filesystem/tests/test_sqlite.py::test_yosemite_data_csv_artifact PASSED [ 35%]
dsi/drivers/filesystem/tests/test_sqlite.py::test_query PASSED           [ 42%]
dsi/drivers/filesystem/tests/test_sqlite.py::test_artifact_query PASSED  [ 50%]
dsi/plugins/tests/test_env.py::test_hostname_plugin_type PASSED          [ 57%]
dsi/plugins/tests/test_env.py::test_hostname_plugin_col_shape PASSED     [ 64%]
dsi/plugins/tests/test_env.py::test_hostname_plugin_row_shape PASSED     [ 71%]
dsi/plugins/tests/test_env.py::test_envprov_plugin_type PASSED           [ 78%]
dsi/plugins/tests/test_env.py::test_envprov_plugin_adds_rows PASSED      [ 85%]
dsi/plugins/tests/test_env.py::test_bueno_plugin_type PASSED             [ 92%]
dsi/plugins/tests/test_env.py::test_bueno_plugin_adds_rows PASSED        [100%]

============================== 14 passed in 2.55s ==============================

@qwofford qwofford merged commit 30c2635 into lanl:qwofford/issue14 Jun 22, 2023
@qwofford qwofford linked an issue Jun 29, 2023 that may be closed by this pull request
@qwofford qwofford removed a link to an issue Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants