WIP: Update submodules, API changes, tracer swarm packs, formatting CI #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstroBarker
changed the title
AstroBarker
changed the title
Yurlungur
reviewed
Jan 17, 2025
There was a problem hiding this comment.
This is a lot of work! Thanks for going through this @AstroBarker ! I don't see anything offhand that might be causing the changes in the regression tests we see, so let's do the tests we discussed.
There was a problem hiding this comment.
at some point we might want to change to a different clang-format version
There was a problem hiding this comment.
whoopsy daisy. good catch.
|
|
||
| auto receive = | ||
| tl.AddTask(send, &SwarmContainer::Receive, sc.get(), BoundaryCommSubset::all); | ||
| auto defrag = tl.AddTask(receive, &SwarmContainer::Defrag, sc.get(), 0.9); |
There was a problem hiding this comment.
doing this every cycle probably isn't necessary
| tl.AddTask(none, radiation::MOCMCTransport<MDT>, sc0.get(), dt); | ||
| auto send = tl.AddTask(samples_transport, &SwarmContainer::Send, sd0.get(), | ||
| BoundaryCommSubset::all); | ||
| tl.AddTask(none, radiation::MOCMCTransport<MDT>, base.get(), beta * dt); |
Comment on lines
-494
to
-501
| // TODO(BRR): Hack to get around current lack of support for packing parthenon swarms | ||
| template <> | ||
| TaskStatus MOCMCFluidSource(MeshData<Real> *rc, const Real dt, const bool update_fluid) { | ||
| for (int n = 0; n < rc->NumBlocks(); n++) { | ||
| MOCMCFluidSource(rc->GetBlockData(n).get(), dt, update_fluid); | ||
| } | ||
| return TaskStatus::complete; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Far overdue, this PR updates
parthenon,singularity-eos, andsingularity-opacand makes necessary changes to work with their updated versions.Updates to MHD (API changes for packing)
Overhauls to swarm API
MeshDataThe advection problem's tracers were refactored due to a bug on multiple blocks
Some updates to BCs, probably more simplification can be done.
The fast logs of
singularity-eosare default disabled.Updates neutrino mean opacity API
Tracers:
MeshDatainstead ofMeshBlockDataSWARM_VARIABLESnow, so access with e.g.,tv::rho(),tv::rho::name()e.g., (fornamespace tv = tracer_variables;to enable type based packing.Also, the github
ubuntu-latestchanged andclang-format-12was no longer available. I have moved us to installingclang-formatwithpip, pinned at version12.0.1. Which was not compatible with ubuntu's v12...Weirdness seems to have crept in to the regression testing. Some tests, despite producing an identical gold file (when ran with
--upgold) failed tests due to how hdf5 was loaded. Unsure what caused this change, but a fix was implemented.