Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Templated MD arrays #39

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
+751 −383
Open

Draft: Templated MD arrays #39

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f29eaf7
initial commit
Oct 2, 2023
7a8e259
spelling + comments
Oct 2, 2023
4c13c2c
added PORTABLE_ function preambles to missing ones
Oct 3, 2023
4742b0b
getting build/exec on GPUs
mauneyc-LANL Oct 4, 2023
4bf821e
fix indexing
mauneyc-LANL Oct 4, 2023
4863827
some design changes
mauneyc-LANL Oct 5, 2023
1492a98
tests and benchmarks
Aug 14, 2024
36e848c
Merge branch 'main' into mauneyc/templated_md
Aug 14, 2024
551910b
store
Aug 29, 2024
9ab0b9b
merge
Aug 30, 2024
352077a
Merge branch 'main' into mauneyc/templated_md
Aug 30, 2024
0f66ba1
array and index algs
Aug 30, 2024
ece0a3c
comment cleanup and copyright
Aug 30, 2024
6668587
short comments in algos
Aug 30, 2024
825301a
removed unneeded parameter
Aug 30, 2024
703397a
some sloppy juggling of types
Sep 4, 2024
195fecf
working on stuff
Oct 8, 2024
f2431e1
add span
Nov 15, 2024
e64866d
merge main
Nov 15, 2024
3c769f2
undo span changes
Nov 19, 2024
9733f80
removed benchmark testing; fix some tests for gpu
mauneyc-LANL Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,14 @@ target_compile_features(${POCLIB}
cxx_std_14
)

#NOTE this option is done downstream, maybe poc should control it
set(with_cxx "$<COMPILE_LANGUAGE:CXX>")
set(ps_kokkos "$<BOOL:${PORTABILITY_STRATEGY_KOKKOS}>")

target_compile_options(${POCLIB}
INTERFACE
$<${with_cxx}:$<${ps_kokkos}:--expt-relaxed-constexpr>>)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the event of +kokkos~cuda, wouldn't this result in a compile error?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it, but POC doesn't have a USE_CUDA or similar like singularity-eos does, so I need to probe which compiler is being used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how I've done it in other projects:

  get_target_property(kokkos_link_libs Kokkos::kokkoscore
                      INTERFACE_LINK_LIBRARIES)
  string(REGEX MATCH "CUDA"
         kokkos_has_cuda_libs "${kokkos_link_libs}")
  ...
  if(kokkos_has_cuda_libs)
    do cuda stuff...
  endif()


# TESTING
# ----------------------------------------
if(PORTS_OF_CALL_BUILD_TESTING)
Expand Down
Loading
Loading