Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer static vector from Singe #46

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Transfer static vector from Singe #46

merged 6 commits into from
Oct 15, 2024

Conversation

BrendanKKrueger
Copy link
Collaborator

PR Summary

A GPU-capable implementation of static vector. This is a std::vector-like data structure built on top of a std::array-like backing store, resulting in something with a compile-time capacity but a run-time size. It works on both the CPU and the GPU, and can be transferred between the two.

PR Checklist

  • Any changes to code are appropriately documented.
  • Code is formatted.
  • Install test passes.
  • Docs build.
  • If preparing for a new release, update the version in cmake.

@BrendanKKrueger BrendanKKrueger added the enhancement New feature or request label Aug 26, 2024
@BrendanKKrueger BrendanKKrueger self-assigned this Aug 26, 2024
@BrendanKKrueger BrendanKKrueger marked this pull request as ready for review August 29, 2024 20:21
Yurlungur
Yurlungur approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty neat! Could you also add to the docs showing this capability exists?

ports-of-call/static_vector.hpp Show resolved Hide resolved
ports-of-call/static_vector.hpp Outdated Show resolved Hide resolved
test/test_static_vector_kokkos.cpp Show resolved Hide resolved
@Yurlungur
Copy link
Collaborator

@dholladay00 are you happy with this? If so will merge.

@dholladay00
Copy link
Collaborator

@dholladay00 are you happy with this? If so will merge.

yep 👍

@Yurlungur Yurlungur merged commit 707ad53 into main Oct 15, 2024
4 checks passed
@Yurlungur Yurlungur deleted the bkk_static_vector branch October 15, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@dholladay00 dholladay00 dholladay00 approved these changes

Assignees

@BrendanKKrueger BrendanKKrueger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrendanKKrueger @Yurlungur @dholladay00