Revise testing system to make it easier to add new tests #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
approved these changes
Aug 28, 2024
test/CMakeLists.txt
Outdated
|
|
||
| target_link_libraries(test_portsofcall | ||
| add_executable(test_main test_main.cpp) |
There was a problem hiding this comment.
Would prefer if the test executable was still named test_portsofcall
Suggested change
| add_executable(test_main test_main.cpp) | |
| add_executable(test_portsofcall test_main.cpp) |
though maybe this suggests the test_portsofcall.cpp file should be called something like test_portability.cpp or something
test/CMakeLists.txt
Outdated
|
|
||
| target_link_libraries(test_portsofcall | ||
| add_executable(test_main test_main.cpp) | ||
| target_link_libraries(test_main |
There was a problem hiding this comment.
Suggested change
| target_link_libraries(test_main | |
| target_link_libraries(test_portsofcall |
test/CMakeLists.txt
Outdated
| PRIVATE | ||
| ports-of-call::ports-of-call | ||
| portsofcall_iface | ||
| ) | ||
|
|
||
| include(Catch) | ||
| catch_discover_tests(test_portsofcall) | ||
| catch_discover_tests(test_main) |
There was a problem hiding this comment.
Suggested change
| catch_discover_tests(test_main) | |
| catch_discover_tests(test_portsofcall) |
test/CMakeLists.txt
Outdated
|
|
||
| target_sources(test_main PRIVATE test_portsofcall.cpp) |
There was a problem hiding this comment.
Suggested change
| target_sources(test_main PRIVATE test_portsofcall.cpp) | |
| target_sources(test_portsofcall PRIVATE test_portsofcall.cpp) |
|
Feel free to push back on my suggestions here. I'm happy to merge as is. |
…ng test_main.cpp because that file is really just doing all the compilation for main.
|
I migrated us to catch2 v3 and added a fetch content line to the cmake so we can get catch even if it's not available via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In #48 I did a very hacky job of adding new tests, and @Yurlungur rightly pointed out that it's not ideal. There could be a variety of ways to handle this, but I stole shamelessly from Singe to propose a new way to handle new unit test files. Now new files should only need to be added to the
target_sourcescommand at the end oftest/CMakeLists.txt.PR Checklist