Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move target logic into test cmakelist #53

Merged
merged 4 commits into from
Sep 4, 2024
Merged

move target logic into test cmakelist #53

merged 4 commits into from
Sep 4, 2024

Conversation

Yurlungur
Copy link
Collaborator

PR Summary

Ports of call doesn't set the portability strategy in cmake. Must be set downstream. Here we fix the tests so it is set for testing purposes.

PR Checklist

  • Any changes to code are appropriately documented.
  • Code is formatted.
  • Install test passes.
  • Docs build.
  • If preparing for a new release, update the version in cmake.

@Yurlungur Yurlungur added the bug Something isn't working label Aug 29, 2024
@Yurlungur Yurlungur self-assigned this Aug 29, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
@Yurlungur
Copy link
Collaborator Author

@rbberger please re-review

CMakeLists.txt Outdated Show resolved Hide resolved
@Yurlungur
Copy link
Collaborator Author

@rbberger one more review please. :) I think all concerns are addressed. If you're happy with it now, please click approve.

@rbberger
Copy link
Collaborator

rbberger commented Sep 4, 2024

@Yurlungur Added a small bug fix to the Spackage as well.

@Yurlungur Yurlungur merged commit b8392bc into main Sep 4, 2024
4 checks passed
@Yurlungur Yurlungur deleted the jmm/cleanup-tests branch September 4, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants