Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be == instead of =. #55

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Should be == instead of =. #55

merged 1 commit into from
Sep 13, 2024

Conversation

BrendanKKrueger
Copy link
Collaborator

PR Summary

Fix a typo that somehow slipped in.

PR Checklist

  • Any changes to code are appropriately documented.
  • Code is formatted.
  • Install test passes.
  • Docs build.
  • If preparing for a new release, update the version in cmake.

@BrendanKKrueger
Copy link
Collaborator Author

@Yurlungur, I found a typo and tried building things to make sure there weren't others. I get errors with Catch2, but it's not clear if there's a problem with the code or my environment or other. When you get a chance, would you mind trying to build and see if it works or not?

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoopsie thanks for the fix

@Yurlungur Yurlungur merged commit debb60c into main Sep 13, 2024
4 checks passed
@Yurlungur Yurlungur deleted the bkk_typo branch September 13, 2024 20:52
@BrendanKKrueger
Copy link
Collaborator Author

whoopsie thanks for the fix

I'm pretty sure I put that typo in, so it's only fair that I fix it :-)

@Yurlungur Yurlungur mentioned this pull request Sep 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants