Add config_summary to Ports-of-Call. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, if you want to see how this looks for Singe as an example, Diego has a screenshot here. |
Yurlungur
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
THis is nice. I think @mauneyc-LANL at some point tried to implement something like this but maybe not in ports.
mauneyc-LANL
approved these changes
Oct 10, 2024
|
Let me know if these are the right options to display for Ports-of-Call, because I wasn't sure. |
|
It seems totally reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
A recent addition to Singe. Jonah said Ports-of-Call might find it useful, so putting together a demo so y'all can see if you like it or not.
@Yurlungur @dholladay00 @cmauney
PR Checklist