Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix config_summary #65

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix config_summary #65

merged 1 commit into from
Nov 19, 2024
+2 −0

Conversation

BrendanKKrueger
Copy link
Collaborator

PR Summary

Export the Catch2 and Kokkos version variables up a level so that the config_summary machinery can find them.

PR Checklist

  • Any changes to code are appropriately documented.
  • Code is formatted.
  • Install test passes.
  • Docs build.
  • If preparing for a new release, update the version in cmake.

Yurlungur
Yurlungur approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@BrendanKKrueger
Copy link
Collaborator Author

Tested and it fixes the issue.

@BrendanKKrueger BrendanKKrueger marked this pull request as ready for review November 19, 2024 16:10
@BrendanKKrueger BrendanKKrueger mentioned this pull request Nov 19, 2024
Open
3 tasks
@Yurlungur Yurlungur merged commit b9e5d1d into main Nov 19, 2024
4 checks passed
@Yurlungur Yurlungur deleted the bkk_version_strings branch November 19, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrendanKKrueger @Yurlungur