Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake updates; flush with upstream #246

Merged
merged 75 commits into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from 56 commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
16d1dce
removed submodules
mauneyc-LANL Mar 29, 2023
583bdb3
CMake updates, new dependency handling, submodules removed
mauneyc-LANL Mar 29, 2023
446855e
variant update
mauneyc-LANL Mar 30, 2023
00f00a2
Revert "removed submodules"
mauneyc-LANL Apr 3, 2023
f8cadbc
use kernels, update paths
mauneyc-LANL Apr 3, 2023
52e9a21
moved kokkos SMs to 3.7.01
mauneyc-LANL Apr 3, 2023
a808196
bifurcate build strategy
mauneyc-LANL Apr 3, 2023
0ae0dde
removed relocatable kokkos configure option
mauneyc-LANL Apr 4, 2023
6bce674
options and consistancy checks
May 2, 2023
654b060
merge main
May 2, 2023
bbe7985
Merge branch 'main' into mauneyc/flush-with-upstream
May 16, 2023
539e52b
updates
May 17, 2023
a120a48
updates
Jun 6, 2023
efc524f
debugging hdf5
mauneyc-LANL Jun 6, 2023
74583f5
merge dev
mauneyc-LANL Jun 6, 2023
5b9557d
add presets (gpu only for now)
mauneyc-LANL Jun 6, 2023
83a9999
Merge branch 'main' into mauneyc/flush-with-upstream
mauneyc-LANL Jun 6, 2023
c45b102
explicit reference to HL libs; this may need a little work
mauneyc-LANL Jun 7, 2023
15a4e19
trying to reason about HDF5 libs
mauneyc-LANL Jun 7, 2023
081ded1
Update the github CI yamls
mauneyc-LANL Jun 7, 2023
c7009b2
debugging githubCI
mauneyc-LANL Jun 7, 2023
041ba89
force SM mode on CI
mauneyc-LANL Jun 7, 2023
0de14e5
update docs CI
mauneyc-LANL Jun 7, 2023
528f6d0
temp debug on CI
mauneyc-LANL Jun 7, 2023
a1e23f9
pleading with HDF5 to stop
mauneyc-LANL Jun 7, 2023
35ab328
Presets
Jun 19, 2023
005c284
install stage update, testing configs
Jun 21, 2023
ea5580a
clarifying build, testing GPU
mauneyc-LANL Jun 22, 2023
5218c11
ignore user presets; draft of build guide
Jun 22, 2023
0f911dc
Merge branch 'mauneyc/flush-with-upstream' of github.com:lanl/singula…
Jun 22, 2023
dc40e74
use updates to spiner in branch, undo when spiner updated
Jun 23, 2023
583ec22
moved spiner sm to dev branch -- revert to main before merging
Jun 23, 2023
3a5d7f5
moved poc sm to main
Jun 23, 2023
83c715c
updated github test with correct options
Jun 23, 2023
691d38b
spackage updates and spiner alignment
Jun 27, 2023
bf08ff2
initial CI change
Jun 27, 2023
7a2529f
github CI turn off HDF5 on minimal test
Jun 27, 2023
a5267f3
change/add databox definition
Jun 28, 2023
dcd783a
adding to build doc
Jun 28, 2023
9eb7b68
databox template simplification
Jun 28, 2023
dd35609
moved databox declaration to out of singularity scope
Jun 28, 2023
7e8c808
Merge branch 'main' into mauneyc/flush-with-upstream
Jul 10, 2023
8820059
remove -d from spack env command
ktsai7 Jul 10, 2023
10cbd45
Merge branch 'mauneyc/flush-with-upstream' of ssh://re-git.lanl.gov:1…
Jul 11, 2023
520555e
add sesame2spiner with databox update
Jul 11, 2023
54df12f
disable sesame2spiner if eospac is off
Jul 11, 2023
c74554f
add new databox to test_pte
mauneyc-LANL Jul 11, 2023
4adceb4
update spiner spackage to accecpt lesser cmake version
mauneyc-LANL Jul 12, 2023
c5512bf
more README doc
Jul 26, 2023
da1e86e
Add missing eosSafeDestroy call
rbberger Jul 6, 2023
309b80a
Update CHANGELOG.md
rbberger Jul 6, 2023
8b0cbc8
Fix GitHub bot workflow
rbberger Jul 12, 2023
a4d97f8
CI spec and spackage change
Jul 27, 2023
d27e5e4
Some spackage adjustments
Jul 27, 2023
f0a8818
Sphinx build doc rewrite
Jul 27, 2023
b430eef
Merge branch 'main' into mauneyc/flush-with-upstream
Yurlungur Jul 27, 2023
fc9993b
Merge branch 'main' into mauneyc/flush-with-upstream
Yurlungur Jul 27, 2023
11270f8
format
jonahm-LANL Jul 27, 2023
69ae1ac
Merge branch 'main' into mauneyc/flush-with-upstream
Yurlungur Jul 31, 2023
d0c31b1
add 'build' to gitignore
Jul 31, 2023
7284fea
merge main and manual fix changes
Jul 31, 2023
598ae6d
variant target guard, removed spiner flags
Jul 31, 2023
1d1ec1c
fixed typo in description
mauneyc-LANL Jul 31, 2023
c3883cc
change description
mauneyc-LANL Jul 31, 2023
02a6d2b
check for closure for LA lib
Jul 31, 2023
aa5c913
format file and remove spiner+kokkos defines
Jul 31, 2023
d5a9bab
moved closure option and include eigen logic
Jul 31, 2023
554fe22
check for cuda/eigen
Jul 31, 2023
5ec9ec4
fixed missing endif
Jul 31, 2023
17883de
merge main and fix conflict
Jul 31, 2023
8855477
update spackage for version diffs
Jul 31, 2023
5e8130b
removed dead code
Jul 31, 2023
4b439d3
removed marco for out-of-source kokkos source
Jul 31, 2023
9d7efa2
Merge branch 'main' into mauneyc/flush-with-upstream
Yurlungur Aug 1, 2023
36c6233
Merge branch 'main' into mauneyc/flush-with-upstream
dholladay00 Aug 2, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ jobs:
- name: build code
run: |
mkdir -p build
cmake -DSINGULARITY_BUILD_PYTHON=ON -DSINGULARITY_USE_HDF5=OFF -DSINGULARITY_USE_FORTRAN=OFF -B build .
cmake -DSINGULARITY_BUILD_PYTHON=ON \
-DSINGULARITY_USE_SPINER=ON \
-DSINGULARITY_USE_SPINER_WITH_HDF5=OFF \
-DSINGULARITY_FORCE_SUBMODULE_MODE=ON \
-B build .
cmake --build build
sudo cmake --install build
- name: build docs
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,16 @@ jobs:
cd bin
mkdir -p ${HOME}/install
cmake -DCMAKE_INSTALL_PREFIX=${HOME}/install \
-DSINGULARITY_USE_SPINER=ON \
-DSINGULARITY_BUILD_TESTS=ON \
-DSINGULARITY_BUILD_EXAMPLES=ON \
-DSINGULARITY_BUILD_PYTHON=ON \
-DSINGULARITY_USE_HDF5=ON \
-DSINGULARITY_TEST_SESAME=OFF \
-DSINGULARITY_TEST_PYTHON=ON \
-DSINGULARITY_TEST_STELLAR_COLLAPSE=ON \
-DSINGULARITY_FORCE_SUBMODULE_MODE=ON \
..
#-DSINGULARITY_TEST_PYTHON=ON \
#-DSINGULARITY_TEST_STELLAR_COLLAPSE=ON \
#..
make
make install
make test
9 changes: 3 additions & 6 deletions .github/workflows/tests_minimal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,10 @@ jobs:
cd bin
mkdir -p ${HOME}/install
cmake -DCMAKE_INSTALL_PREFIX=${HOME}/install \
-DSINGULARITY_USE_SPINER=ON \
-DSINGULARITY_USE_SPINER_WITH_HDF5=OFF \
-DSINGULARITY_BUILD_TESTS=ON \
-DSINGULARITY_BUILD_PYTHON=OFF \
-DSINGULARITY_USE_HDF5=OFF \
-DSINGULARITY_BUILD_CLOSURE=OFF \
-DSINGULARITY_TEST_SESAME=OFF \
-DSINGULARITY_TEST_PYTHON=OFF \
-DSINGULARITY_TEST_STELLAR_COLLAPSE=OFF \
-DSINGULARITY_FORCE_SUBMODULE_MODE=ON \
..
make
make install
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ spack-build-*
spack-configure-*
._*
*.sublime*
CMakeUserPresets.json

15 changes: 8 additions & 7 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ variables:
SINGULARITY_EOS_GCC_VERSION: "9.3.0"
SINGULARITY_EOS_OPENMPI_VERSION: "4.1.3"
SINGULARITY_EOS_CUDA_VERSION: "11.6.0"
SINGULARITY_EOS_SPACK_SPEC: "singularity-eos@main+mpi+python+tests%gcc@${SINGULARITY_EOS_GCC_VERSION} ^openmpi@${SINGULARITY_EOS_OPENMPI_VERSION}"
SINGULARITY_EOS_SPACK_SPEC: "singularity-eos@main+mpi+hdf5+python+tests%gcc@${SINGULARITY_EOS_GCC_VERSION} ^openmpi@${SINGULARITY_EOS_OPENMPI_VERSION}"
COLOR_CYAN: '\033[1;36m'
COLOR_PLAIN: '\033[0m'
# set to different spack upstream for testing
Expand Down Expand Up @@ -51,7 +51,7 @@ before_script:

.gpu: &gpu
SINGULARITY_USE_CUDA: "true"
SINGULARITY_EOS_SPACK_SPEC: "singularity-eos@main+mpi+tests+cuda+kokkos cuda_arch=70 +kokkos-kernels%gcc@${SINGULARITY_EOS_GCC_VERSION} ^cuda@${SINGULARITY_EOS_CUDA_VERSION} ^openmpi@${SINGULARITY_EOS_OPENMPI_VERSION}"
SINGULARITY_EOS_SPACK_SPEC: "singularity-eos@main+mpi+tests+cuda+kokkos+hdf5 cuda_arch=70 +kokkos-kernels%gcc@${SINGULARITY_EOS_GCC_VERSION} ^cuda@${SINGULARITY_EOS_CUDA_VERSION} ^openmpi@${SINGULARITY_EOS_OPENMPI_VERSION}"

.fort: &fort
SINGULARITY_USE_FORTRAN: "true"
Expand Down Expand Up @@ -103,8 +103,8 @@ before_script:
then
echo -e "\e[0Ksection_start:`date +%s`:spack_build[collapsed=true]\r\e[0K${COLOR_CYAN}Building via Spack${COLOR_PLAIN}"
mkdir -p spack_build_env
spack env create -d spack_build_env
spack env activate -d spack_build_env
spack env create spack_build_env
spack env activate spack_build_env
spack repo add spack-repo
spack config add upstreams:default:install_tree:${SINGULARITY_EOS_SPACK_DIR}/opt/spack/
spack dev-build -j $(nproc) ${SINGULARITY_EOS_SPACK_SPEC}
Expand All @@ -113,8 +113,8 @@ before_script:
fi
- echo -e "\e[0Ksection_start:`date +%s`:spack_env[collapsed=true]\r\e[0K${COLOR_CYAN}Creating Spack environment${COLOR_PLAIN}"
- mkdir -p spack_env
- spack env create -d spack_env
- spack env activate -d spack_env
- spack env create spack_env
- spack env activate spack_env
- spack repo add spack-repo
- spack config add upstreams:default:install_tree:${SINGULARITY_EOS_SPACK_DIR}/opt/spack/
- spack spec -I ${SINGULARITY_EOS_SPACK_SPEC}
Expand All @@ -133,7 +133,8 @@ before_script:
- |
cmake -DCMAKE_INSTALL_PREFIX=${CI_PROJECT_DIR}/install ${SINGULARITY_CMAKE_CXX_COMPILER_FLAG} \
-DSINGULARITY_USE_EOSPAC=ON \
-DSINGULARITY_USE_HDF5=ON \
-DSINGULARITY_USE_SPINER=ON \
-DSINGULARITY_USE_SPINER_WITH_HDF5=ON \
-DSINGULARITY_BUILD_SESAME2SPINER=ON \
-DSINGULARITY_BUILD_STELLARCOLLAPSE2SPINER=ON \
-DSINGULARITY_BUILD_PYTHON=${SINGULARITY_BUILD_PYTHON:-OFF} \
Expand Down
7 changes: 5 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
url = https://gitlab.com/libeigen/eigen.git
[submodule "utils/spiner"]
path = utils/spiner
url = ../spiner.git
url = https://github.com/lanl/spiner
[submodule "utils/variant"]
path = utils/variant
url = https://github.com/mpark/variant.git
Expand All @@ -12,4 +12,7 @@
url = https://github.com/kokkos/kokkos.git
[submodule "utils/ports-of-call"]
path = utils/ports-of-call
url = ../ports-of-call.git
url = https://github.com/lanl/ports-of-call.git
[submodule "utils/kokkos-kernels"]
path = utils/kokkos-kernels
url = https://github.com/kokkos/kokkos-kernels.git
Loading